search

ilektrojohn / creepy

A geolocation OSINT tool. Offers geolocation information gathering through social networking platforms.
http://www.geocreepy.com
GNU General Public License v3.0
1.25k stars 303 forks source link

Port from pyexiv2 to GExiv2. #25

Closed ghost closed 11 years ago

ghost commented 11 years ago

pyexiv2 is unmaintained, and as long as you continue to use it, you'll never be able to port your app to Python 3. This pull request ports your app off pyexiv2 onto GExiv2, a much newer module that sports support for Python 3, making it easy to port your app to Python 3 later on.

I apologize in advance for the sloppiness of this diff; my editor is configured to automatically strip trailing whitespace, and you had a lot of it. If you look past that and pay attention to how much simpler the gexiv2 code is compared to pyexiv2, I'm sure you'll welcome the change.

Thanks.

ilektrojohn commented 11 years ago

Hi Robert ! Thanks a lot for the pull request, it looks great and solves some issues with the pyexiv2 version support in different platforms. I 'll take a more careful look and pull the changes ASAP. Thanks again for your time and commit !

ghost commented 11 years ago

Glad to hear it. Please do let me know if you find any problems. I will admit I wrote it somewhat hastily so I may have overlooked something!

On Wed, Jan 2, 2013 at 1:05 PM, Ioannis Kakavas notifications@github.comwrote:

Hi Robert ! Thanks a lot for the pull request, it looks great and solves some issues with the pyexiv2 version support in different platforms. I 'll take a more careful look and pull the changes ASAP. Thanks again for your time and commit !

— Reply to this email directly or view it on GitHubhttps://github.com/ilektrojohn/creepy/pull/25#issuecomment-11824186.

Troubles are handled with propriety and no delay, all I have to do is draw the anchor up and float away. -- Buck 65

ghost commented 11 years ago

@ilektrojohn, I was able to simplify this even a little bit further for you ;-)

ghost commented 11 years ago

Much to my dismay, GExiv2 0.6 just shipped with a slightly changed API that breaks this pull request (get_date_time method has been removed from the API, despite my wishes). What this means is that your app is currently broken on Ubuntu Raring (13.04).

I'll submit a new pull request for you soon, sorry for the inconvenience!