search

ilent2 / ott

Optical Tweezers Toolbox (Version 1)
Other
52 stars 31 forks source link

bsc_pointmatch_focalplane: Unused parameters that should be used #3

Closed ilent2 closed 6 years ago

ilent2 commented 6 years ago

In bsc_pointmatch_focalplane, parameters(1), parameters(2) and parameters(4) are not used. These should be used or documented as depreciated.

beam_type is not used, however the documentation says it should choose the beam type LG/HG.

AStilg commented 6 years ago

Remove the claim that it works for HG beams. Add a warning that users should use bsc_pointmatch_farfield instead.

ilent2 commented 6 years ago

Fixed in https://github.com/ilent2/ott/commit/6bcac3d31b6e8764aab559fdc71ddf313e455bbe