Closed pascalfree closed 10 years ago
I have no Android tablet to test this, can I assume your commit is complete and tested ?
Thanks for the contributions !
Hi,
I've tested the fix on a real Galaxy Tab2 10.1 and on an emulated Nexus 10. Also I have been using the fixed version on my phone in the last 10 days without a problem. So yes, I think it's complete and tested.
More pull requests will follow :-)
More pull requests welcome :)
Hi again, another little cosmetic fix. On tablets the settings screen (and therefore the first screen a user will see of the app) looks like this: Borders are visible left and right, while the content does not seem to fit into this box, especially the checkbox.
It seems to be a problem with using a single preferenceFragment inside a preferenceActivity. The official Settings guide states: "You can add a PreferenceFragment to any activity—you don't need to use PreferenceActivity" Apparently it's even necessary not use a PreferenceActivity here.
I assume, an other solution would be not to use the PreferenceFragment, although the developer guide recommends to use it.