search

ilgarmehmetali / budgie-weather-applet

GNU General Public License v2.0
7 stars 3 forks source link

compilation warning messages #14

Open fossfreedom opened 6 years ago

fossfreedom commented 6 years ago

During compilation see the following warnings - something to worry about?

../src/BudgieWeatherApplet.vala:45.9-45.34: warning: Gtk.Widget.margin_left has been deprecated since 3.12
../src/BudgieWeatherApplet.vala:45.38-45.64: warning: Gtk.Widget.margin_right has been deprecated since 3.12
../src/BudgieWeatherApplet.vala:49.9-49.29: warning: Gtk.Widget.margin_left has been deprecated since 3.12
../src/BudgieWeatherApplet.vala:49.33-49.59: warning: Gtk.Widget.margin_right has been deprecated since 3.12
../src/BudgieWeatherApplet.vala:66.36-66.39: warning: Argument 1: Cannot pass null to non-null parameter type
        new GWeather.LocationEntry(null);
                                   ^^^^

build log https://launchpadlibrarian.net/360636309/buildlog_ubuntu-bionic-i386.budgie-weather-applet_0.1-0ubuntu2~bionic+build3_BUILDING.txt.gz

ubuntu budgie 18.04 building against GNOME 3.28 gweather library

ilgarmehmetali commented 6 years ago

I cant exactly remember what but i had some problems with margins and i had to use deprecated properties. Should try the new properties and see if i would still face with problems.

Last warning is because of a little hack and is related to this: https://github.com/ilgarmehmetali/budgie-weather-applet/blob/210d3c36b7a066b28018a4c2d7c9aa4017b903f4/src/BudgieWeatherApplet.vala#L65-L66

None of them should cause any trouble for the time being but it would be better to find better solutions.

fossfreedom commented 6 years ago

ok - I can do a PR with the new properties and an alternative solution for the "null" hack.

However concerned that the applet update button is behaving very intermittently - see the issue about the compilation problems