Not signing AAB

[DatL4g]

I build an apk file and an aab file and move them to the same location.

$ ls ./app/release/
app-release-unsigned.apk
app-release.aab

Then I want to sign them both with this action

- uses: ilharp/sign-android-release@v1
      id: sign_app
      with:
        releaseDir: app/release
        signingKey: ${{ secrets.ANDROID_SIGNING_KEY }}
        keyAlias: ${{ secrets.ANDROID_KEY_ALIAS }}
        keyStorePassword: ${{ secrets.ANDROID_KEYSTORE_PASSWORD }}
        buildToolsVersion: 30.0.2

However the action signs the apk file only

Now sign 1 files:
- app-release-unsigned.apk
...
Verification succesful
  Signing APK file.
  /usr/local/lib/android/sdk/build-tools/30.0.2/apksigner sign --ks *** --ks-key-alias *** --ks-pass pass:*** --out app/release/app-release-unsigned-signed.apk app/release/app-release-unsigned-temp.apk
Successfully signed 1 files.

The aab file is ignored

[ilharp]

https://github.com/ilharp/sign-android-release/blob/deb41877e1975adeb2b314f536be2797e2934a23/src/main/kotlin/Main.kt#L43

Seems like there's an extra $ here. It's a typo. I'm fixing it now.

[ilharp]

Bugfix commit pushed. Could you please try the nightly version (can use a temporary branch for testing)? If this fixes the bug, i'll release a new version immediately, and subsequent CIs will use the new version.

- uses: ilharp/sign-android-release@nightly

[DatL4g]

Works now, thanks for the fast fix

[ilharp]

v1.0.1 released. It's now safe to revert to v1.