search

ilia10000 / dataset-distillation

Soft-Label Dataset Distillation and Text Dataset Distillation
MIT License
73 stars 6 forks source link

Uncorrected errors in the github #2

Open data-science-lover opened 2 years ago

data-science-lover commented 2 years ago

Hello, I'm writing this message just to inform you that the corrections made on the github https://github.com/SsnL/dataset-distillation have not been done here.

As a result, errors such as "State." missing before UniqueNamespace() in the "base_options.py" file persist.

ilia10000 commented 2 years ago

Thanks! I'll try to merge those soon (just need to verify that they don't break anything) or alternatively happy to merge a PR if anyone else makes them.

data-science-lover commented 2 years ago

Thanks! I'll try to merge those soon (just need to verify that they don't break anything) or alternatively happy to merge a PR if anyone else makes them.

Hi, I don't know how merge ... another modification was made in the initial directory (in base_options.py) because yaml.load(f) was problematic for more recent versions. On my side, by specifying the loader, the problem was solved: yaml.load(f, Loader=yaml.FullLoader)