Add vignette filter - Githubissues

ilia3101 / MLV-App

All in one MLV processing app.

https://mlv.app/

GNU General Public License v3.0

283 stars 29 forks source link

Add vignette filter #150

Closed masc4ii closed 5 years ago

masc4ii commented 5 years ago

We already wrote some lines about that in #49 . There I thought it may be best to change exposure value for best results. This also should be true, but my concept was too limiting to do so. Another solution is to change brightness instead of exposure. And here we have no problem at all. I made a proof of concept and it looks not too bad. Which parameters should we realize?

brightness
inner radius (where nothing happens)
outer radius is diagonal line from center to corner (const)

Realization: from center to boarder:

no effect until inner radius
from inner radius to boarder 1st/4 of cos() function (or is another function better here?

masc4ii commented 5 years ago

Hm... maybe forget about it... with latest tests I am not impressed at all 😢

Using exposure: looks perfect. Using RGB values: colors change saturation Using HSL luminance: looks like a mobile phone effect

masc4ii commented 5 years ago

When thinking about, I got another idea which affects exposure as well. And I really like the results. Works fine with linear gradient as well. bildschirmfoto 2019-02-20 um 13 29 21 Next I need to include transformation settings to the calculation...

masc4ii commented 5 years ago

Transformation working now too. Last problem: sometimes I get crashes, when first playing with a small clip and then switching to a bigger one (resolution). Seems like new vignette mask is generated while still rendering old picture... thought we don't allow this. Strange.

masc4ii commented 5 years ago

Chrash problem should be solved in commit already. (hopefully, but did not get it reproduced again after a small change)