Release discussion v1.10

[masc4ii]

Last release is online since 53 days. Time for v1.10? Have you tested the new features? Are there still bugs? Are there some news for the other latest 6 issues, or do you plan to implement something for that in the next days? New draft is created.

[ilia3101]

I think we should release. True, I still have not done the tonemapping function thing. Let's leave this for 10.11 (I keep coming up with stuff to do but it takes way longer than I plan because I always want to do too much 😢)

I think the fixed memory leak is almost by itself a whole reason to release.

[ilia3101]

Ah, there's one thing that's been annoying me on Linux since forever, but I keep forgetting to say it: When I scroll through the right panel, if the mouse happens to go over a combobox, scrolling will stop and it will start scrolling through the options of the combobox. It does not do this on mac.

Maybe there's a simple method in Qt to stop combobox option scrolling? Or an option in interface builder.

[masc4ii]

Yes... thanks for writing this. That has been annoying me too. But until now I was too lazy to change it. I'll have to subclass QComboBox and forbid QScrollEvent to work 😄 I made the same for all the sliders already ("NoScrollSlider.cpp/h"). Will do that in the next days!

[ilia3101]

Thanks!!!

[masc4ii]

Could you please test? Now when hovered and scrolled it gets focus, but don't changes the value.

Edit: the wheel focus problem is solved too now.

[ilia3101]

Very sorry for the slow response. Just tested it on Linux: does not work - still scrolls through the options.

I made 100% sure by deleting old MLV-App folder and git cloning again, same result 😢

[masc4ii]

Ok, thx. Will try tomorrow on Linux.

[masc4ii]

Oh yes... little missunderstanding on my side. SpinBoxes did the same and I fixed them yesterday. Comboboxes were still as before. Fixed that now too. 😄

[ilia3101]

Big big improvement for Linux this is.

[ilia3101]

Are you going to include raw2mlv in the 1.10 release then?

[masc4ii]

If you like, we could do. It is very beta stage, but works nicely here.

[ilia3101]

I think we should release it now without raw2mlv, and whoever wants to have it can compile it for now. And the next 1.11 release should be sooner than 53 days. By 1.11 I will make raw2mlv much more usable and create that custom tonemapping feature.

Raw2mlv issues:

• Lens info not set
• Date/time not set (surprisingly painful, having to convert time_t structure to MLV time field)
• No compression

[masc4ii]

Yes, right. Many of the file information fields in MLVApp stay empty with those MLVs. I can comment that feature out easily for now.

[DeafEyeJedi]

Compiled w latest commits. Love the simplicity of transcoding and importing the CR2 files w raw2mlv and have a play for MLV App.

Am I crazy for thinking it seems more fluid and quicker when working with photos and sliders are more responsive than it lags in previous commits?

New code helped w this improvement?

Sent from my iPhone XR

On Nov 21, 2019, at 11:21 PM, masc4ii notifications@github.com wrote:

Yes, right. Many of the file information fields in MLVApp stay empty with those MLVs. I can comment that feature out easily for now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[masc4ii]

Hm... don't think it is faster now or slower now. We did not change anything in general.

[masc4ii]

@ilia3101 & @bouncyball-git : here is the source commit: https://github.com/ilia3101/MLV-App/commit/33bfe6189a468e689616893672b6fde4461317d9

I'll upload the binaries on monday or so... @bouncyball-git : are you able to compile Win64 static version (pleeeaaaaase)?

[ilia3101]

I wonder if I could try compiling windows 64 static, do I just need Qt for it?

I think I remember something like needing to compile Qt yourself for 64 bit :/

[ilia3101]

Am I crazy for thinking it seems more fluid and quicker when working with photos and sliders are more responsive than it lags in previous commits?

Would be nice. But I don't think so :(

[masc4ii]

I wonder if I could try compiling windows 64 static, do I just need Qt for it?

I think I remember something like needing to compile Qt yourself for 64 bit :/

Japp, you have to compile Qt yourself for 64bit static. For 64bit dynamic you could use the latest downloads.

[cmhamiche]

You could use MSYS2, this is what I did. https://www.msys2.org If you are familiar with Archlinux's pacman, you can install pretty much anything like qt-static and qt creator. Here's some more info: https://wiki.qt.io/MSYS2 (the wiki is wrong about "no static edition of QtCreator").

If you install everything at the default path, here's the project file I used (that could be cleaned up I recon): https://github.com/cmhamiche/mlvapp_win/blob/master/MLVApp.pro

I can provide a static version but I also understand if you prefer @bouncyball-git to manage this. Edit: what I could do tho is to test if everything's fine on a virtual machine.

[cmhamiche]

raw2mlv is missing few DLLs namely vcruntime140.dll, vcruntime140_1.dll and msvcp140.dll.

edit: disregard vcruntime140.dll, it's shipped already.

[ilia3101]

Hmm I might not be able to do it easily right now, my windows VM is on a computer with almost no disk space left, so can't really install anything like MSYS2, even in the virtual machine.

[ilia3101]

raw2mlv is missing few DLLs namely vcruntime140.dll, vcruntime140_1.dll and msvcp140.dll.

The version we have in MLV App right now? It's the one I compiled before, I guess they should be included then. The DLL situation on windows is so strange.

[masc4ii]

raw2mlv is missing few DLLs namely vcruntime140.dll, vcruntime140_1.dll and msvcp140.dll.

Win32 version runs without problem on Wine on OSX.

[cmhamiche]

raw2mlv is missing few DLLs namely vcruntime140.dll, vcruntime140_1.dll and msvcp140.dll.

The version we have in MLV App right now? It's the one I compiled before, I guess they should be included then. The DLL situation on windows is so strange.

The one included on the repo right now. I tested on a fresh install of Windows in Virtualbox. If you release as is, you should ask garry23 to report back (without him overwriting existing files from his previous folder ofc) as he couldn't get raw2mlv to work without those DLLs .

raw2mlv is missing few DLLs namely vcruntime140.dll, vcruntime140_1.dll and msvcp140.dll.

Win32 version runs without problem on Wine on OSX.

"Wine Is Not an Emulator" is pretty different from a full Windows install.

[masc4ii]

Yes, the one included in the repos.

"Wine Is Not an Emulator" is pretty different from a full Windows install.

Right. That's why it mostly cry's even more than Windows, if something is missing. 😄

[cmhamiche]

[masc4ii]

Funny. But in Wine I did not install one single VC runtime. Normally every VC proggi needs that.

[DeafEyeJedi]

Really? That’s funny. Gonna try to run Wine.

Sent from my iPhone XR

On Nov 23, 2019, at 12:28 PM, cmh notifications@github.com wrote:

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[cmhamiche]

Wine's team is partially implementing C runtime libraries since 1.2 or something and this is still ongoing. It will probably throw that error at you if you set vcruntime140_1.dll and msvcp140.dll to native.

edit: checking on winehq "If the application uses MFC library (Microsoft Foundation Classes), there will be no replacement hence installation of Microsoft Redistributables is a requirement for applications and games to work!"

Microsoft Foundation Class Library on Wikipedia: "MFC is a library that wraps portions of the Windows API in C++ classes, including functionality that enables them to use a default application framework. Classes are defined for many of the handle-managed Windows objects and also for predefined windows and common controls."

Since there's not much "common controls" and windows and eye candy on raw2mlv, wine's implementation is enough.

[cmhamiche]

I couldn't compile with OpenMP previously, this is now fixed. Here's the updated project file for a static Windows build, if needed: https://raw.githubusercontent.com/cmhamiche/mlvapp_win/master/MLVApp/MLVApp.pro

[DeafEyeJedi]

Does this mean openMP is fixed to compile on OS X as well running Catalina?

Sent from my iPhone XR

On Nov 23, 2019, at 2:36 PM, cmh notifications@github.com wrote:

I couldn't compile with OpenMP previously, this is now fixed. Here's the updated project file for a static Windows build, if needed: https://raw.githubusercontent.com/cmhamiche/mlvapp_win/master/MLVApp/MLVApp.pro

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[cmhamiche]

Nope, it has nothing to do with OSX. Sorry.

[dannephoto]

Does this mean openMP is fixed to compile on OS X as well running Catalina? … Sent from my iPhone XR On Nov 23, 2019, at 2:36 PM, cmh @.***> wrote: I couldn't compile with OpenMP previously, this is now fixed. Here's the updated project file for a static Windows build, if needed: https://raw.githubusercontent.com/cmhamiche/mlvapp_win/master/MLVApp/MLVApp.pro — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

Already working on Catalina. Only your computer set up seems affected.

[masc4ii]

I couldn't compile with OpenMP previously, this is now fixed. Here's the updated project file for a static Windows build, if needed: https://raw.githubusercontent.com/cmhamiche/mlvapp_win/master/MLVApp/MLVApp.pro

Thanks @cmhamiche ! But I guess it will only create static builds with that? I think I'll add it (if you don't mind), add some comments (howto use) and transform it a very little bit. Okay?

[cmhamiche]

Sure thing.

[bouncyball-git]

are you able to compile Win64 static version (pleeeaaaaase)?

Sure! :grin:

[masc4ii]

are you able to compile Win64 static version (pleeeaaaaase)?

Sure! 😁

Don't forget the new ffmpeg (is in the repos). Thanks!

[bouncyball-git]

I guess in repository there is only 32bit ffmpeg. I downloaded 64bit ffmpeg.exe version 4.2.1 (as in the repo) and put it into zip. Is it ok or maybe that binary from repo custom compiled and supports some stuff officcial binary doesn't?

[bouncyball-git]

https://www.videohelp.com/software/ffmpeg this is the best source for binaries for windows.

Edit: just uploaded. Works on my latest win10.

[bouncyball-git]

Of course 32bit ffmpeg.exe will work but let it be pure 64bit release.

[masc4ii]

Ah, you're right, thanks. It was the standard build 4.2.1. Maybe we should add that to our repos as well. Then we know that it works (in future)...

[masc4ii]

Yeeehaaa...