search

ilia3101 / MLV-App

All in one MLV processing app.
https://mlv.app/
GNU General Public License v3.0
274 stars 30 forks source link

Profile menu not updating itself on select? #276

Open Randrianasulu opened 9 months ago

Randrianasulu commented 9 months ago

I tried to compile MLV-App on Slackware 15.0 i586 (but actual cpu is AMD FX 4300, so plenty of SIMD extensions).

Compile was fine (I used src up to 620d7c8e7ddfd2f13d7bc03253e9d0af14a7d7d0).

But after starting resulting App and playing with ElgersburgBHF.zip (5 seconds MLV file I found on forum) I noticed Profile dropdown menu does not change its content on select, so I was a bit confused about its working.

Next one (Processing gamut) works as intended, showing selected mode on itself.

I am not familiar with qt, looking at last git commit message ( "Set msgbox default buttons") may be some updates were missed?

masc4ii commented 9 months ago

This combobox is a pre-seletion of presets. It sets up the transfer function and the processing gamut. You should see these options:

Bildschirmfoto 2023-10-08 um 19 44 59

If you select for example the Davinci option, you should get this:

Bildschirmfoto 2023-10-08 um 19 45 15
Randrianasulu commented 9 months ago

This combobox is a pre-seletion of presets.

Yes, but shouldn't its text reflect active selected preset?

masc4ii commented 9 months ago

No. Because then it would be incorrect in nearly all cases. The preset is a combination of processing gamut and a unique equation. The formula is changeable. There are endless possibilities. A preset is just one of that.

Randrianasulu commented 9 months ago

No. Because then it would be incorrect in nearly all cases. The preset is a combination of processing gamut and a unique equation. The formula is changeable. There are endless possibilities. A preset is just one of that.

hm, may he then ONLY replace 'Select preset' text with 'Custom' or 'Custom, click to change" IF changes were made?

or at least indicate it in statusbar somewhere?

masc4ii commented 9 months ago

Why adding this additional complexity (the profile thing is very complex already now), as everything is custom (apart from those few presets)? You always see what you selected below. And if you're not sure, select it another time again. A text "custom" in a combobox, which is autoselected but not manually selectable... I don't know.