Wrong audio info for files without audio

[masc4ii]

Opening a file without audio (e.g. the file EOS100D.MLV which we got from the forum), the file information tells: doesMlvHaveAudio( m_pMlvObject ) = true getMlvAudioChannels( m_pMlvObject ) = 0 getMlvSampleRate( m_pMlvObject ) = 0

That does not fit... The App behaviour may be wrong using this information, for example ffmpeg export with audio export activated can't work because of the empty WAV file.

[masc4ii]

This little change helps in video_mlv.h: #define doesMlvHaveAudio(video) (((video)->MLVI.audioClass) && ((video)->WAVI.channels > 0)) But why (video)->MLVI.audioClass has wrong information?

[ilia3101]

This may even be a bug in magic lantern? I will have to see. I could add a double check for audio(check for AUDF blocks) and make a has_audio property in the mlvObject itself.

EDIT: Actually see that you fixed it, is this bug worth "closing"?

[masc4ii]

No, I did not fix it. I could do with that line above... it works, but is that good? Your idea would be better, but makes more work.

[ilia3101]

Ah ok, I'll keep that in mind, it's on my to-do list then. I'll make all these little changes once bouncyball's work is merged to avoid conflicts.

[DeafEyeJedi]

Agreed. Good idea!

On Sep 18, 2017, at 2:41 PM, Ilia Sibiryakov notifications@github.com wrote:

Ah ok, I'll keep that in mind, on my list/ I'll make all these little changes once bouncyball's work is merged to avoid conflicts.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ilia3101/MLV-App/issues/5#issuecomment-330364614, or mute the thread https://github.com/notifications/unsubscribe-auth/AU_1o1FkhcLhDhhmfRjXmIrzgsKO7JMBks5sjuN0gaJpZM4Palqs.

[masc4ii]

Did the temporary fix mentioned above in this commit

[masc4ii]

@ilia3101 : you fixed this by 8a2af3b? Or do you wanted to do more?