QtApp: Crash on enabling filter

[seescho]

With no mlv loaded: no crash With a mlv loaded: crash With qt-creator in debug-mode: no crash ???

When I enable filter, mlvapp freezes. After 10 seconds mlvapp crash:

Speicherzugriffsfehler (Speicherabzug geschrieben)

I went back to this commit: "fixed compilation error saying type 'uint16_t' is not defined" Result: crash

My compile-log tell me this warning for a implicit declaration:

g++ -o filter.o ../../src/processing/filter/filter.c ../../src/processing/filter/filter.c: In function ‘initFilterObject’: ../../src/processing/filter/filter.c:41:24: warning: implicit declaration of function ‘fmemopen’; did you mean ‘freopen’? [-Wimplicit-function-declaration]

No clue, if that´s important for the crash

I can reproduce the crash with opensuse-leap and opensuse-tumbleweed

See also discussion on ml-forum: https://www.magiclantern.fm/forum/index.php?topic=20025.msg197099#msg197099

[masc4ii]

The problem is strtod(..) in genann.c, it is locale dependant.

[bouncyball-git]

Please do what I wrote above comment strtod and uncomment sscanf and try

Both working for me as expected, sscanf can be local independent.

[masc4ii]

It happens the same.

[masc4ii]

Okay. Add this in the first line of genann_read and all is fine here (please test): setlocale( LC_ALL, "C" ); And add #include <locale.h>

Edit: works on all 3 platforms for me.

[bouncyball-git]

There also "strtod_l" (with last parameter local_t local) but I can not make it work.

[bouncyball-git]

Thanks, committed. Now I hope everything works as expected.

[ilia3101]

Yay ❤️ so when is it time to release???????

[bouncyball-git]

I'm all for it :)

[masc4ii]

Maybe let's wait for eschos test, and then let's release! 😃

[bouncyball-git]

Yes this makes sense :)

[masc4ii]

I already uploaded the OSX version to the release page as draft. @bouncyball-git : when @seescho tells that all is fine, just upload Win64 version and press "Publish release" ;-)

[bouncyball-git]

@seeschooooooo where are youuu? :)

[seescho]

back again :) Will do some tests later this evening

[bouncyball-git]

Oh, thanks god, our German jury is here :)

[seescho]

Hihihi. The road was long (I dreamed, I came with the ISS): https://seescho.wordpress.com/

I cannot force a crash anymore. And the colors are fine now. I love you all, guys :)

I would say: Let´s go to the new release...

[masc4ii]

WOW! Great picture! Ist ja der Wahnsinn! 😄

[masc4ii]

@bouncyball-git : you know what your job is?! 😆

[bouncyball-git]

@seescho I'm sure you are hiding unpublished pics of Elon's Roadster somewhere ;)

@masc4ii Yup I know :) What about 32bit one?

[masc4ii]

I can build the 32bit version... but that needs 2h until my Windows super machine has booted...

[bouncyball-git]

Nice if you can compile 32bit. I can connect to my work with vpn and log into my Linux box and compile 64bit version in ssh console.

[seescho]

@bouncyball-git Elon´s Roadster? Nope. But I documented The First Contact, some time ago: https://seescho.wordpress.com/2016/08/17/der-erste-kontakt/

[bouncyball-git]

Unfortunately I don't read German but pics are self explanatory and cool :)

[bouncyball-git]

@masc4ii Done, uploaded

Let's close this issue.

[masc4ii]

RELEASED!

[ilia3101]

🎉 Yay finally!Y!

@seescho Wow that is an amazing picture 🛰