search

iliaal / php_excel

PHP Extension interface to the Excel writing/reading library
http://ilia.ws
533 stars 131 forks source link

xlSheetCellType override #261

Closed username31480 closed 3 years ago

username31480 commented 4 years ago

Adds parameter to the ExcelSheet::read function enabling override of the cell type value returned by xlSheetCellType. Doing so allows control over whether php_excel_read_cell uses xlSheetReadStr or xlSheetReadNum.

An example where this is useful would be reading long fully numeric serial numbers or IMEIs, where xlSheetCellType might indicate CELLTYPE_NUMBER, and xlSheetReadNum might return the value in exponential notation.

do-io commented 3 years ago

@username31480

Could you make this a gist and submit it for info, please.

While this is a good help, it does change the behavior of the product in a way that not all would be amenable.

username31480 commented 3 years ago

Forgive me, I do not know what you are asking of me. I am not familiar with git workflow, and I do not what it is to make something "a gist" in this scope.

On Fri, May 14, 2021, 11:53 Darren Odden @.***> wrote:

@username31480 https://github.com/username31480

Could you make this a gist and submit it for info, please.

While this is a good help, it does change the behavior of the product in a way that not all would be amenable.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iliaal/php_excel/pull/261#issuecomment-841370613, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEY6E42P7BURZ2KM2U3VJYLTNVIQ3ANCNFSM4OYXJWLQ .

do-io commented 3 years ago

https://www.jetbrains.com/help/webstorm/share-code-with-gists.html

alternatively, this can be made as a patch: https://devconnected.com/how-to-create-and-apply-git-patch-files/