search

iliaal / php_excel

PHP Extension interface to the Excel writing/reading library
http://ilia.ws
533 stars 131 forks source link

Recent merge commits cause compile errors #268

Closed jwestbrook closed 3 years ago

jwestbrook commented 3 years ago

on the php7 branch during make

/usr/src/libxl/libxl-3.9.2.1/include_c/libxl.h:474:30: error: too many arguments to function 'xlSheetInsertRowA'
/usr/src/libxl/libxl-3.9.2.1/include_c/libxl.h:473:30: error: too many arguments to function 'xlSheetInsertColA'
/usr/src/libxl/libxl-3.9.2.1/include_c/libxl.h:476:30: error: too many arguments to function 'xlSheetRemoveRowA'
/usr/src/libxl/libxl-3.9.2.1/include_c/libxl.h:475:30: error: too many arguments to function 'xlSheetRemoveColA'

I updated to the latest libxl 3.9.4.3 as well and the same error was thrown during compile

Jan-E commented 3 years ago

Could you try it with the php7_with_pulls branch of my fork: git clone -b php7_with_pulls https://github.com/Jan-E/php_excel

jwestbrook commented 3 years ago

Yep your branch compiles cleanly with 3.9.2.1 and 3.9.4.3

do-io commented 3 years ago

@Jan-E can you PR the php7_with_pulls