iliakan / plunk

Utility to post to plnkr.co
19 stars 14 forks source link

http://plnkr.co/edit/undefined?p=preview #15

Open FrancescoMussi opened 7 years ago

FrancescoMussi commented 7 years ago

Just discover this package. It is a very much needed one!

But unfortunately it is not working for me. I have followed all the steps but after I run the plunk command I get this:

http://plnkr.co/edit/undefined?p=preview

Do you know why?

iliakan commented 7 years ago

Are you on Windows? What did you do?

FrancescoMussi commented 7 years ago

I am on Mac. I have done these steps:

My node version is: v6.9.5

sjsnider commented 7 years ago

exact same thing happens for me...

iliakan commented 7 years ago

I'd really love to reproduce that issue :/ Tried on a new Mac, it worked.

akshitrewari commented 7 years ago

I'm on windows and getting the same issue. Followed all steps correctly.

My node version is 7.7.2

jacobbutton commented 7 years ago

Same issue. Windows 7

Install plunk globally Authorize with .plunk_config.json run plunk get error about missing module "chalk" npm install chalk in plunk directory back to project directory run plunk http://plnkr.co/edit/undefined?p=preview

Shpiller commented 7 years ago

Same issue. Ubuntu

Install plunk globally Authorize with .plunk_config.json run plunk get error about missing module "chalk" npm install chalk globally back to project directory run plunk http://plnkr.co/edit/undefined?p=preview

node -v v7.9.0

chalk@1.1.3

ishandutta2007 commented 7 years ago

For valid codes there are no issues. The codes which are breaking the cli are the codes which doesn't save successfully on plunker. ie which throws 400 (Bad Request) on pressing the save button at plunkr

screen shot 2017-05-22 at 10 35 09 am

I think we should modify it to throw appropiate error than fail silently.

iliakan commented 7 years ago

What you mean? Plunker does not compile the code, it's not a compiler.

How to reproduce the problem?

ishandutta2007 commented 7 years ago

Steps to reproduce the problem:

iliakan commented 7 years ago

How to write such code that gives 400? My code saves successfully. :)

ishandutta2007 commented 7 years ago

sorry I am not able to produce now either, but was surely able to earlier the way I mentioned above, can't recall what exactly I did that time, I am not faking, see I had posted sceenshot earlier too. For now I am able to reproduce another way, for any large repo, I keep deleting files/directories one by one and keep running plank incrementally, it succeeds below a certain limit of folder size(most probably 2MB). So most likely its a scaling issue.

ishandutta2007 commented 7 years ago

It would be better if you could skip binary files/assets and only whitelist for cetain file extenstions, and after that if the directory is still too big to upload maybe upload partially and notify the user about it.

pawod commented 7 years ago

I had the same problem as described above, when running this tool on windows. Excluding the project's /img folder solved it. Seems like this tool can't handle .jpg or .gif files.