Could you add Illumous build to gorelease?

ilijamt / vault-plugin-secrets-gitlab

Vault Plugin for Gitlab Access Tokens

MIT License

46 stars 7 forks source link

Could you add Illumous build to gorelease? #103

Closed gaige closed 4 months ago

gaige commented 4 months ago

Current code works great with Illumos/SmartOS, but release builds aren't available for download.

I've run build, test, and release on SmartOS as well as confirming that functions work against an existing gitlab (private) instance using the current release version of vault (which has a solaris/illumos binary).

The only change that was necessary to add in our environment was adding illumos to the os list in goreleaser.yaml file.

If you'd prefer a PR, I'm happy to put one in.

ilijamt commented 4 months ago

Either would have been fine with me. But since this is very quick fix. I've added it, you should have a version 0.4.1 with the illumos build as well.