search

ilijamt / vault-plugin-secrets-gitlab

Vault Plugin for Gitlab Access Tokens
MIT License
45 stars 7 forks source link

feat: add gitlab revoke option so vault doesn't revoke the token when the parent expires #52

Closed ilijamt closed 8 months ago

ilijamt commented 8 months ago

Allow us to skip the vault revocation process, and let Gitlab revoke the tokens.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 97.64706% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.95%. Comparing base (1825ae7) to head (ce4e8f9).

Files Patch % Lines
secret_access_tokens.go 90.90% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ========================================== + Coverage 87.88% 87.95% +0.07% ========================================== Files 15 15 Lines 949 955 +6 ========================================== + Hits 834 840 +6 Misses 68 68 Partials 47 47 ``` | [Flag](https://app.codecov.io/gh/ilijamt/vault-plugin-secrets-gitlab/pull/52/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ilija+Matoski) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ilijamt/vault-plugin-secrets-gitlab/pull/52/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ilija+Matoski) | `87.95% <97.64%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ilija+Matoski#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.