Draft: fix: auto_rotate_before needs to be longer than config token duration

ilijamt / vault-plugin-secrets-gitlab

Vault Plugin for Gitlab Access Tokens

MIT License

43 stars 6 forks source link

Closed TJM closed 2 months ago

TJM commented 3 months ago

NOTE: this one is built upon #90 since I needed that to do my testing. If we need to, I can rebase this so that they are separate.

Changes:

Cleans up the minutely debug log messages
Removes some redundant code
Adds Token Validation and checks the duration of the config token against the auto_rotate_before, because it needs to be longer or it will rotate the config token every minute.

TODO: Fix unit tests, token validation will require additional mock responses

ilijamt commented 2 months ago

Because I didn't want to mock the responses, I opted for the approach in #97 which uses real instances and stores the responses locally for replay.