Final Project Feedback

[kuldeep23907]

Hi Ilija Petronijevic – I am Kuldeep, a mentor who is assisting with the grading. Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend Comments:

• UI looks awesome. Maybe we can change the color combo to make texts clear a bit but good work anyways.
• Kovan testnet
• Good to see you used Github Pages for MVP deployment.

Testing comments:

• Testcases structured properly.
• Contract work is good. We should focus on modularising it using inter-contract calls and interfaces. Avoid using loops if possible or optimize it well.
• Bonus for using brownie and pytest.

Contract Comments:

• Contract work is good. We should focus on modularising it using inter-contract calls and interfaces. Avoid using loops if possible or optimize it well.
• Circuit-break pattern as Pausable has been used. Inheritance, Interfaces, and Oracles have been used from Openzeppelin and Chainlink. Access Control Design has been used too.
• Overflow/underflow is handled. Safe ETH withdrawal using owner validation seems to work fine.
• Using AggregatorV3Interface seems a very good use of it.

Overall:

• I liked the idea of the project. I liked the fact that Vyper has been used. It provides a bit diversity to the blockchain development ecosystem. Please try this idea in a hackathon. Keep working on this! Oracle use case makes it better. Glad to see so much experiment in POC.
• Connect/Disconnect wallet helps in good UI/UX. Also liked that whenever the network changes, the latest network name is shown on UI. The ability to add COOP token directly to metamask comes in handy. Really awesome work on front-end.
• Account change can be handled too on the front-end.
• UI works very well. Appreciate the way the Readme file on GitHub explains the steps to follow. Smart Contract is written well but can be made more secure. All test cases are successful too. Really liked the project and appreciate the effort put into it. I will encourage you to keep learning and participate in hackathons to showcase your skills.

Hope you enjoyed the learning journey so far and can continue building on this.

[ilijapet]

Thanks Kuldeep! You made my day!! :-))