ilikecats567 / arduino

Automatically exported from code.google.com/p/arduino
Other
0 stars 0 forks source link

DHCP client doesn't handle multiple DNS server addresses in DHCP response #569

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
With the new Arduino 1.0 Ethernet library with the DHCP client included, if 
your DHCP server returns more than one DNS server address for use it fails to 
parse the remainder of the DHCP response correctly.

This often results in the Ethernet chip not being configured correctly (which 
can sometimes be spotted if the netmask and/or gateway IP address are set to 
0.0.0.0) and the Arduino won't be able to communicate over Ethernet

Original issue reported on code.google.com by adrian.m...@gmail.com on 7 Jul 2011 at 8:57

GoogleCodeExporter commented 9 years ago
Ah, on looking into submitting a pull request for my fix to this, I found 
https://github.com/arduino/Arduino/pull/33 which is an alternate fix and had 
slipped past my radar.  I haven't tested that alternate fix, but from reading 
through the code it seems fine, so I'm happy for either to get applied.

Original comment by adrian.m...@gmail.com on 7 Jul 2011 at 11:00

GoogleCodeExporter commented 9 years ago

Original comment by dmel...@gmail.com on 24 Aug 2011 at 7:00

GoogleCodeExporter commented 9 years ago
Adrian, can you update and check this against the latest Ethernet library code 
(i.e. after merging your latest wifly_integration changes)?  It looks like it 
won't merge cleanly any more as is.

Original comment by dmel...@gmail.com on 31 Aug 2011 at 7:34

GoogleCodeExporter commented 9 years ago
Ah, yes, when I updated the the wifly branch to the latest code I actually 
updated it to the latest version of my fork of Arduino, so it's already got my 
version of this fix applied.  So once the wifly_integration branch is merged 
into the core Arduino this will be fixed.

Original comment by adrian.m...@gmail.com on 31 Aug 2011 at 8:09

GoogleCodeExporter commented 9 years ago
I'm just going through some of the open Ethernet related issues and this one 
seems to be fixed in the master branch in github even though the "chomp" 
implementation refered to in comment 1 might be prettier than the current 
solution.

Someone should perhaps close the issue and the pull request?

Original comment by pe...@birchroad.net on 7 Dec 2011 at 11:04

GoogleCodeExporter commented 9 years ago

Original comment by dmel...@gmail.com on 16 Dec 2011 at 10:08