Closed michael-petersen closed 1 year ago
Another dependency:
from tqdm import tqdm
. This one seems less strictly necessary -- perhaps make optional? Or add to requirements.astropy
matplotlib
? Though this is not strictly required and could be debated.h5py
?It actually appears that >=Python 3.11
is required, specifically to support:
itertools.pairwise
is used for Backend.iter_orbit_slices
, which isn't yet used by the library - however, I have re-implemented it for now using itertools.tee
(copying from the itertools documentation).typing.dataclass_transform
is just a typing utility, I have removed it for Python-version backwards compatibility.astropy
is used for the Coordinate
classes, I have added this to the package requirements.tqdm
isn't strictly necessary, I will add it to the requirements for now and add a note for removing it in a later commit.h5py
and matplotlib
can be made as class-specific requirements, so using ExtendImports
is a reasonable solution here. I think matplotlib
should still be made a requirement since a big part of the analysis package's functionality depends on it.I've addressed all but the last point in the latest commit.
I think this is all solved now by various testing schemes and upgrades.
It looks like there is some
>=Python 3.10
functionality scattered around. Starting a list here:examples/using_galpy/phase_slice.py
withpairwise
fromitertools
Perhaps get around by requiring
Python 3.10
?