search

ilime / Petal

🌺 Douban.FM Client With Extra - - - 一个简洁的豆瓣FM客户端。
https://ilime.github.io/Petal/
MIT License
470 stars 38 forks source link

Fix Node v10.0.0 incompatible module error, upath@1.0.4: The engine "… #11

Closed raindust closed 6 years ago

raindust commented 6 years ago

…node" is incompatible with this module. Expected version ">=4 <=9".

g1eny0ung commented 6 years ago

This is an annoying problem when you using the yarn command.

But we shouldn't edit the .lock file directly, it's an anti-pattern.

According to https://github.com/anodynos/upath/issues/14:

This is an indirect dependency of webpack (webpack -> watchpack -> chokidar -> upath), so the current engines flag prevents any webpack user from upgrading to node 10.

I will upgrade the related package after soon.

Thx for PR. 👍

g1eny0ung commented 6 years ago

Fixed in f335663698a265e5e50de99144151d81a32bf19e.

raindust commented 6 years ago

Ok, i see: ) This repo is really a good job, and mabe the only active Douban.FM on mac. So let's hold on~

g1eny0ung commented 6 years ago

Thx. @raindust