search

ilios / ember-simple-charts

Some easy to use charts made with ember and D3
https://ember-simple-charts.netlify.app/
Other
5 stars 7 forks source link

Convert to pnpm #1078

Closed jrjohnson closed 11 months ago

jrjohnson commented 11 months ago

Should make it easier to manage our workspaces.

Converted all the scripts to use this Cleaned up dependency issues Used the CI steps from the default ember blueprint to install and run

netlify[bot] commented 11 months ago

Deploy Preview for ember-simple-charts failed.

Name Link
Latest commit bc5ffa8a8d43bc5a981147995da0854dfcaced94
Latest deploy log https://app.netlify.com/sites/ember-simple-charts/deploys/652d607d5c3a2400085f97bf
jrjohnson commented 11 months ago

The failure to build on netlify here is expected. Once this is merged I'll fix our install and build scripts over there to get this working.

stopfstedt commented 11 months ago

tested locally. both the demo-app and the test-app built and started successfully. however, i am seeing output errors on shutdown.

stefan@nichtsnutz: ~/dev/projects/ember-simple-charts on pnpm[$]
$ pnpm run start:docs

> ember-simple-charts@ start:docs /home/stefan/dev/projects/ember-simple-charts
> pnpm run --filter docs start

> docs@0.0.0 start /home/stefan/dev/projects/ember-simple-charts/packages/docs
> ember serve

Build successful (5845ms) – Serving on http://localhost:4200/

Slowest Nodes (totalTime >= 5%)          | Total (avg)
-----------------------------------------+-----------
ember-auto-import-webpack (1)            | 4121ms    
ember-auto-import-analyzer (6)           | 316ms (52 ms)

cleaning up...
/home/stefan/dev/projects/ember-simple-charts/packages/docs:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  docs@0.0.0 start: `ember serve`
Command failed with signal "SIGINT"
 ELIFECYCLE  Command failed.

not sure how relevant this is though.

stopfstedt commented 11 months ago

pnpm support in Ember - starting with v5.3.0

https://rfcs.emberjs.com/id/0907-pnpm-support/

we're still on 4.x here.