search

ilius / pyglossary

A tool for converting dictionary files aka glossaries. Mainly to help use our offline glossaries in any Open Source dictionary we like on any modern operating system / device.
GNU General Public License v3.0
2.15k stars 239 forks source link

Convert to Apple Source missing attribute #567

Open chicman opened 1 month ago

chicman commented 1 month ago

I was converting some Stardict to AppleSource. I found "info.plist", the CFBundleIdentifier is missing.

According to Apple Document, this is critical for the Application to ID each dictionary. Here is part of the doc.

`[2-6] Info.plist

Edit each value of the followings in the Info.plist If you use different file name for this plist, you need to edit the variable 'PLIST_PATH' for it in Makefile.

<key>CFBundleDevelopmentRegion</key>
<string>English</string>
<key>CFBundleDisplayName</key>
<string>My Dictionary</string>
<key>CFBundleIdentifier</key>
<string>com.your_company.dictionary.MySample</string>

`

I've tested, if any of the dictionary has the CFBundleIdentifier filled empty, when the search have results in multiple dicts, it will be blank in "all" tab. Result tabs for each dictionary will also not in place.

I think it is better if the converting would combine some string + numbers to generate a unique value as ID. Solves the problem!

ilius commented 1 month ago

I pushed a fix. Please try again.