ilius / starcal

StarCalendar: Full-featured International Calendar for Linux Desktop
https://ilius.github.io/starcal/
GNU Affero General Public License v3.0
153 stars 22 forks source link

Correct "Official Holidays of Iran, Islamic Republic of" for 1394 jalali year #12

Closed amirkarimi closed 9 years ago

amirkarimi commented 9 years ago

It seems that "Official Holidays of Iran, Islamic Republic of" doesn't work correctly in 1394 as it shows 5th Farvardin as holiday which is incorrect.

ilius commented 9 years ago

It can't be because of that plugin, 5th Farvardin has never been holiday Please paste the contents of this file ~/.starcal2/core.conf or send it to my email

amirkarimi commented 9 years ago

Here the core.conf file

version='2.3.4'

allPlugList=[
  loadPlugin('/usr/share/starcal2/plugins/iran-jalali.spg', enable=True, show_date=False),
  loadPlugin('/usr/share/starcal2/plugins/iran-gregorian.spg', enable=True, show_date=False),
  loadPlugin('/usr/share/starcal2/plugins/iran-hijri.spg', enable=True, show_date=False),
  loadPlugin('/usr/share/starcal2/plugins/iran-ancient.spg', enable=False, show_date=False),
  loadPlugin('/usr/share/starcal2/plugins/iran-jalali-2.spg', enable=False, show_date=False),
  loadPlugin('/usr/share/starcal2/plugins/iran-gregorian-2.spg', enable=False, show_date=False),
  loadPlugin('/usr/share/starcal2/plugins/iran-hijri-2.spg', enable=False, show_date=False),
  loadPlugin('/usr/share/starcal2/plugins/pray_times.py', enable=False, show_date=False),
  loadPlugin('/usr/share/starcal2/plugins/holidays-iran.hol', enable=True, show_date=False),
]

plugIndex=[1, 2, 3, 4, 5, 6, 7, 8]
calTypes.activeNames=['jalali', 'gregorian']
calTypes.inactiveNames=['hijri', 'julian', 'gregorian_proleptic', 'indian_national', 'ethiopian']
holidayWeekDays=[5]
firstWeekDayAuto=False
firstWeekDay=6
weekNumberModeAuto=False
weekNumberMode=7
debugMode=False

And I've also attached an screen shot of the program: screenshot from 2015-03-29 23 54 14

ilius commented 9 years ago

شهادت حضرت فاطمه چهارم فروردین باید باشه نه پنجم Something is wrong with your Hijri (Islamic) calendar configuration Please run this command: rm ~/.starcal2/hijri-monthes.json Then quit the program, and run it again

amirkarimi commented 9 years ago

There is no json file in my ~/.startcal2 folder! I'm using version 2.3.4. Of course there are some json files in ~/.starcal2/event but not hijri-monthes.json.

ilius commented 9 years ago

Please paste the contents of file ~/.starcal2/hijri.conf

amirkarimi commented 9 years ago
hijriAlg=0
hijriUseDB=True
ilius commented 9 years ago

Oh, I just realized your version is too old Install StarCalendar 2.4.1 and the problem will be fixed Please follow the releases feed to keep up to date: https://github.com/ilius/starcal/releases.atom

ilius commented 9 years ago

It's better to Git clone master (stable) branch Or download the snapshot if you don't have Git: http://github.com/ilius/starcal/tarball/master

amirkarimi commented 9 years ago

Thanks. I'm sorry I didn't update Starcal first. The following command fixed the problem:

git pull
sudo ./uninstall
sudo ./install-ubuntu

Note: Already cloned the repo

ilius commented 9 years ago

No problem You also don't have to run "uninstall" when updating

amirkarimi commented 9 years ago

Actually I just ran the install-ubuntu at first, but it caused the Starcal shortcut to run two instances of program!

ilius commented 9 years ago

You can run as many instances as you want for one installation. Starcal does not check if another instance is running or not. But only one deb starcal package will be installed. Even if you run install-debian many times If you run both "install" and install-debian scripts, you will have two installations. "install" script is only for package-wise unsupported distributions like Slackware and gentoo.

amirkarimi commented 9 years ago

Yes! I accidentally run install instead of install-ubuntu but immediately terminated the program. It seems that I wasn't fast enough ;)

Thanks for your support and explanation.