search

ilius / starcal

StarCalendar: Full-featured International Calendar for Linux Desktop
https://ilius.github.io/starcal/
GNU Affero General Public License v3.0
153 stars 22 forks source link

Up/Down keys on keyboard don't work correctly #5

Closed amirkarimi closed 10 years ago

amirkarimi commented 10 years ago

I was able to go next/prev week (with the same day) using Up/Down arrow keys. But it works with an error in new version. I don't know if it's starcal problem or Ubuntu's. I've experienced this error when I migrated to Ubuntu 13.10 and installed the latest version of the startcal.

Here the repro:

  1. Open the main window
  2. Select Sunday/یکشنبه (no mater what day it is)
  3. Press Up arrow key from keyboard
  4. Now current selected day should be Sunday of the previous week but it's Saturday.

Another situation:

  1. Open the main window
  2. Select Sunday/یکشنبه (no mater what day it is)
  3. Press Down arrow key from keyboard
  4. Now current selected day should be Sunday at next week but it's Monday.
ilius commented 10 years ago

Please attach a screenshot of main window, and paste the full error/output text of starcal (run in terminal)

amirkarimi commented 10 years ago

Of course it's a functionality error and I didn't get any error in terminal. Here it's (just warnings):

/usr/share/starcal2/scal2/ui_gtk/starcal2_appindicator.py:81: Warning: /build/buildd/glib2.0-2.38.1/./gobject/gsignal.c:2475: signal 'child-added' is invalid for instance '0x7f5c3400e3f0' of type 'GtkMenu'
  self.set_menu(menu)
/usr/share/starcal2/scal2/ui_gtk/starcal2_appindicator.py:81: Warning: /build/buildd/glib2.0-2.38.1/./gobject/gsignal.c:2475: signal 'child-added' is invalid for instance '0x7f5c3400e590' of type 'GtkMenu'
  self.set_menu(menu)
/usr/share/starcal2/scal2/ui_gtk/starcal2_appindicator.py:81: Warning: /build/buildd/glib2.0-2.38.1/./gobject/gsignal.c:2475: signal 'child-added' is invalid for instance '0x2103700' of type 'GtkMenu'
  self.set_menu(menu)
/usr/share/starcal2/scal2/ui_gtk/starcal2_appindicator.py:81: Warning: /build/buildd/glib2.0-2.38.1/./gobject/gsignal.c:2475: signal 'child-added' is invalid for instance '0x21038a0' of type 'GtkMenu'
  self.set_menu(menu)

And the screenshots are attached.

Start: starcal_screen

After pressing Up key: starcal_screen_afterupkey

After pressing Down key: starcal_screen_afterdownkey

ilius commented 10 years ago

Fixed in both "master" and "next" branches

Although you don't normally need to enable both Month Calendar and Week Calendar But in case you have done so, if month calendar is above, up/down keys move to previous.next week. But if week calendar is above, up/down keys move to previous/next day, and you have to use Page Up and Page Down to move to previous/next week (that moves to previous/next month in case month calendar is above, or the only active view) So actually shortcuts of first (above) view is prior.

amirkarimi commented 10 years ago

Right. It works correctly after closing the Week Calendar. Thanks for fix.