search

iliyantn / websmsdroid

Automatically exported from code.google.com/p/websmsdroid
0 stars 0 forks source link

No contact names and images in SMSdroid #199

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In SMSdroid 0.0.11 rc1 the contact names and their images disappeared. Only 
the phone numbers are shown. Everthing was fine in version 0.0.10.

My contacts are all Google contacts, all phone numbers have an international 
prefix (perhaps this issue is related with the international prefix bug fix 
in this version?).

I tried to clear SMSdroid's cache but this does'nt make any difference.

I'm using HTC Desire (stock ROM, Android 2.1).

Original issue reported on code.google.com by silas.gr...@gmail.com on 5 May 2010 at 7:22

GoogleCodeExporter commented 9 years ago 
I have Android 2.1 too and the same problem but Contact names will shown.

My device is a Motorola Milestone/Droid

Original comment by rpri...@googlemail.com on 5 May 2010 at 7:39

GoogleCodeExporter commented 9 years ago 
I have a Desire (Android 2.1) and i see no contact pictures

Original comment by webster2...@gmail.com on 5 May 2010 at 8:00

GoogleCodeExporter commented 9 years ago 
HTC desire - google contacts only. Same 
problem. In fact I find SOME pictures but 
they DO NOT MATCH to The contacts

Original comment by falk.hau...@gmail.com on 5 May 2010 at 8:42

GoogleCodeExporter commented 9 years ago 
I have the same problem with the Spica. Contact Names are shown but no photo 
and if i 
click to "show contact" it says: "Contact does not exist!" in the old version 
it was 
fine.

Original comment by Sascha.B...@gmail.com on 5 May 2010 at 8:45

GoogleCodeExporter commented 9 years ago 
I got the same issue as #1, Photos dissappeared but names are there.

I noticed you dont cache the photos in mms.db, do you? So it would be something
around the retrieving of the images in ContactsWrapper5:~53. I compiled myself 
and
added log-output for contactId which seems to be fine (integer sth. around 6000
everytime) but the call to
  InputStream is = Contacts.openContactPhotoInputStream(context.getContentResolver(),
ContentUris.withAppendedId(Contacts.CONTENT_URI, contactId));
(http://github.com/felixb/smsdroid/blob/master/src/de/ub0r/android/smsdroid/Cont
actsWrapper5.java#L55)
always returns null.

Hope that is helpful in some way :)

Original comment by clausthalerblubb on 6 May 2010 at 12:46

GoogleCodeExporter commented 9 years ago 
Issue 201 has been merged into this issue.

Original comment by felix.bechstein on 6 May 2010 at 4:54

GoogleCodeExporter commented 9 years ago 
ahh! i hate that contacts shit. it is nearly that crappy as the mms/sms 
database!
i had to change some code because android 1.6 changed it's behavior within the 
same
contacts-API-version to 1.5.

and it is very hard to debug because everything is working fine in emulator and 
both
phones...

@clausthalerblubb: is the context menu wokring as supposed?

Original comment by felix.bechstein on 6 May 2010 at 5:02

GoogleCodeExporter commented 9 years ago 
Ah, actually no it isn't. I forgot about that before.

When i press "View Contact" i get a short note saying "The contact does not 
exist."
but i couldn't find this message in the code so i assume its from the system. 
Seems
kinda unlogic to me because the name and phonenumber are correct...

Original comment by clausthalerblubb on 6 May 2010 at 5:23

GoogleCodeExporter commented 9 years ago 
yep. with API5 aka android 2.0 the contact's IDs are not fix anymore.. the id 
and
name is cached in the mms.db but if the id changes the link to contacts and the 
photo
won't work anymore..

Original comment by felix.bechstein on 6 May 2010 at 5:31

GoogleCodeExporter commented 9 years ago 
please check the attached apk.
i switched to lookupkey for api5

Original comment by felix.bechstein on 6 May 2010 at 6:02

Attachments:

GoogleCodeExporter commented 9 years ago 
Changes nothing for me :/ Still neither contact names nor images.

Original comment by silas.gr...@gmail.com on 6 May 2010 at 6:08

GoogleCodeExporter commented 9 years ago 
silas: could you please tell me some information about the numbers stored in 
your
contacts db and which international prefix is used in your country.

from .10 to .11 i had cut down the number seen in db eg from +4917912345.. to
%7912345.. and switched to SQL like to get all numbers with this postfix.

Original comment by felix.bechstein on 6 May 2010 at 6:14

GoogleCodeExporter commented 9 years ago 
works for me :D

(silas, i uninstalled before installing the new package, then changed option to
display photos again, killed with task-killer and restartet the app.)

Original comment by clausthalerblubb on 6 May 2010 at 6:18

GoogleCodeExporter commented 9 years ago 
but does not display the names.. this is a sure sign that the % thing is not 
working
for him.

Original comment by felix.bechstein on 6 May 2010 at 6:20

GoogleCodeExporter commented 9 years ago 
The numbers are stored in DIN 5008 format in the database eg +49 179 1234567. 
The
interesing thing is that SMSdroid seems to strip the spaces. It shows 
+491791234567
instead. Perhaps you forgot to remove all non digit chars other than + when 
looking
up the name?

Prefix is +49 since I'm from Germany too.

Original comment by silas.gr...@gmail.com on 6 May 2010 at 6:21

GoogleCodeExporter commented 9 years ago 
hmpf. but how should i lookup those numbers :x
i'm not able to strip these string because they are laying in the database.

Original comment by felix.bechstein on 6 May 2010 at 6:26

GoogleCodeExporter commented 9 years ago 
Hm you wrote you can use SQL to lookup the contacts. Isn't there a replace 
function?
Then you could do something like

select * from contact c where replace(c.number, ' ','') like '%1234567'

(without knowing tablenames and so on)

Original comment by silas.gr...@gmail.com on 6 May 2010 at 6:30

GoogleCodeExporter commented 9 years ago 
please try the attached apk.

Original comment by felix.bechstein on 6 May 2010 at 7:25

Attachments:

GoogleCodeExporter commented 9 years ago 
Works perfectly, thanks a lot!

Original comment by silas.gr...@gmail.com on 6 May 2010 at 7:43

GoogleCodeExporter commented 9 years ago 
fixed in source \o/

Original comment by felix.bechstein on 6 May 2010 at 7:48

GoogleCodeExporter commented 9 years ago 
Unfortunately it's not fixed for me with the new version - might be because my 
phone numbers are formatted as 
eg. +49 (176) 1 23 45 67. WebSMS stumbles there, too, when I try to send 
directly from my contacts.

I'd rather not reformat all 600 phone numbers, also this older DIN/ITU norm is 
IMO the most legible.

Original comment by flo.fuer...@gmail.com on 9 May 2010 at 10:19

GoogleCodeExporter commented 9 years ago 
ok. i'll have to find a way to clean up these kind of numbers to :7

Original comment by felix.bechstein on 9 May 2010 at 10:26

GoogleCodeExporter commented 9 years ago 
Issue 204 has been merged into this issue.

Original comment by felix.bechstein on 9 May 2010 at 10:26

GoogleCodeExporter commented 9 years ago 
Did you have a look in the source code at how the Stock SMS App does the 
lookup? It's working fine there with 
my formatting.

Original comment by flo.fuer...@gmail.com on 9 May 2010 at 10:28

GoogleCodeExporter commented 9 years ago 
yep. id did. but i had to change it to fix some other API-change-fuckup.

maybe i'll have to split some more code and move it into the concatcs API 
wrappers.

the problem is, that android 1.6 behaves *different* though it has the same API 
as
android 1.5...

Original comment by felix.bechstein on 9 May 2010 at 10:34

GoogleCodeExporter commented 9 years ago 
hi felix, the apk provided in issue 199 didn´t solve my problem with the 
contact 
pictures.
in the meantime i also updated to v0.0.12 rc2 but this also didn´t solve my 
issue.

now i tested a little with the phone numbers. as i sync the contacts with my 
exchange-server the phone numbers in my contacts are in this format: +49 (171) 
1234567.
In SMSdroid the phone numbers are for example +491711234567. If i save the 
phone 
number in this type of format (without spaces and brackets) SMSdroid remembers 
the 
name and the picture for this phone number...
WebSMS hasn´t any problems with phone numbers with spaces and brackets...

Original comment by florian....@gmail.com on 9 May 2010 at 10:42

GoogleCodeExporter commented 9 years ago 
i think it's the same problem as @flo's.
i'll try to provide a fix tomorrow.
please be patient and ready to test ;)

Original comment by felix.bechstein on 9 May 2010 at 10:47

GoogleCodeExporter commented 9 years ago 
How about using the pre-.10 method on 2.x devices and the new method for 1.6 
and before? (Not rushing you, I 
can live with the current state for now :-) )

Original comment by flo.fuer...@gmail.com on 9 May 2010 at 10:51

GoogleCodeExporter commented 9 years ago 
Mh.. I think it's another reason than the 2.1 guys but my names and image-view 
don't 
work right too. (rc2 on Magic with android 1.6)
I open SMSDroid. All ok. Then I wrote a SMS and in conversation list the 
receiver 
was shown with phone-number (not with name). In thread-view was all ok. I 
closed and 
opend SMSDroid several times. No change. In addition (right word???) of that 
the "not read"-mark didn't disappear (issue 195??).
After I got the answer-SMS the name was shown correctly but the photo was 
away???? 

Now, some houres later I open SMS droid and all is shown correct (photo, name, 
no 
read mark)?!?!?!...

Original comment by fw1977m...@gmail.com on 10 May 2010 at 6:57

GoogleCodeExporter commented 9 years ago 
ok. for some of you, this bug might be a problem.

http://code.google.com/p/android/issues/detail?id=2983

Original comment by felix.bechstein on 10 May 2010 at 7:46

GoogleCodeExporter commented 9 years ago 
But in that case, Contact and picture inethe stock SMS app wouldn't show 
either, right?

Original comment by flo.fuer...@gmail.com on 10 May 2010 at 7:51

GoogleCodeExporter commented 9 years ago 
Handcent SMS for example shows all contact pictures and contact names 
correctly...

Original comment by florian....@gmail.com on 10 May 2010 at 7:54

GoogleCodeExporter commented 9 years ago 
think so.

Original comment by felix.bechstein on 10 May 2010 at 7:55

GoogleCodeExporter commented 9 years ago 
yep. that's why i said: for *some* of you, this *might* be a problem.
i ran into it while testing..

API3+4 seams to work now.
API5 is in test. please be patient and ready to test.

Original comment by felix.bechstein on 10 May 2010 at 7:59

GoogleCodeExporter commented 9 years ago 
@someone:

http://android.git.kernel.org/?p=platform/packages/providers/ContactsProvider.gi
t;a=blob;f=src/com/android/providers/contacts/ContactsProvider2.java;h=57e1e5d7a
a7a2f80cb6265dd44ce7bc641288553;hb=HEAD#l3558

sb.append(Data._ID + " IN (SELECT " + PhoneLookupColumns.DATA_ID
  + " FROM " + Tables.PHONE_LOOKUP
  + " WHERE " + PhoneLookupColumns.NORMALIZED_NUMBER + " LIKE '%");
sb.append(reversed);
sb.append("')");

i belive this is an android bug, but why does it work in other apps.
shouldn't this lines be somthing like:

sb.append(Data._ID + " IN (SELECT " + PhoneLookupColumns.DATA_ID
  + " FROM " + Tables.PHONE_LOOKUP
  + " WHERE " + PhoneLookupColumns.NORMALIZED_NUMBER + " LIKE '");
sb.append(reversed);
sb.append("'%)");

ps: PhoneLookupColumns.NORMALIZED_NUMBER holds all numbers in reversed order. 
eg. +49
(179) 12345 678 -> 8765432197194+

Original comment by felix.bechstein on 10 May 2010 at 8:27

GoogleCodeExporter commented 9 years ago 
further testing confirmed this issue :(

added an issue for android os:
http://code.google.com/p/android/issues/detail?id=8255

but i still need a workaround.

Original comment by felix.bechstein on 10 May 2010 at 8:47

GoogleCodeExporter commented 9 years ago 
found a dirty hack \o/

please test the attached apk.
clear chache in prefs, kill smsdroid, start smsdroid.

when answering: please add your android version again.

Original comment by felix.bechstein on 10 May 2010 at 9:05

GoogleCodeExporter commented 9 years ago 
Did you forget the attachment or is code.google lagging? :-)

Original comment by flo.fuer...@gmail.com on 10 May 2010 at 9:22

GoogleCodeExporter commented 9 years ago 
my fault. sry

Original comment by felix.bechstein on 10 May 2010 at 9:25

Attachments:

GoogleCodeExporter commented 9 years ago 
working fine here, thanks a lot for the effort :-)

Original comment by flo.fuer...@gmail.com on 10 May 2010 at 9:41

GoogleCodeExporter commented 9 years ago 
i tested the apk provided by you a few minutes ago...

it seems that the issue is fixed because i see the contact names instead of 
phone 
numbers now but if i enable contact pictures the app crashes on my phone (sony 
ericsson 
xperia x10, android 1.6)

Original comment by florian....@gmail.com on 10 May 2010 at 9:46

GoogleCodeExporter commented 9 years ago 
@flo: which android/phone?

@florian: please please send me your device logs via sendlog (see market). i'll 
have
a look on that.

Original comment by felix.bechstein on 10 May 2010 at 10:08

GoogleCodeExporter commented 9 years ago 
Milestone, running 2.1

Original comment by flo.fuer...@gmail.com on 10 May 2010 at 10:10

GoogleCodeExporter commented 9 years ago 
felix, log was sent to you by email directly from my phone a few moments ago. i 
hope i 
didn´t make any mistake as this is the first time i´m creating logs on my 
android 
phone.

the apk works fine but if i enable contact pictures in settings and i kill the 
app, 
smsdroid only shows a black screen after restart...

Original comment by florian....@gmail.com on 10 May 2010 at 10:15

GoogleCodeExporter commented 9 years ago 
i need to uninstall and reinstall smsdroid to have the contact pictures 
disabled again 
for using the app (without contact pictures)...

Original comment by florian....@gmail.com on 10 May 2010 at 10:28

GoogleCodeExporter commented 9 years ago 
@florian: i think sony broke that photo api..

here is a fix which should fetch that exception. it will not show you photos, 
but
please try to show them anyway.

Original comment by felix.bechstein on 11 May 2010 at 6:42

Attachments:

GoogleCodeExporter commented 9 years ago 
@felix: I installed the apk, removed ads, enabled contact photos and ... IT 
WORKS!

Thank you so much - great job!!!

Original comment by florian....@gmail.com on 11 May 2010 at 7:33

GoogleCodeExporter commented 9 years ago 
With Version from comment 46 it works. I also had the problem with crashes when
contact pictures are enabled. Pictures are shown now.

Original comment by Hueb...@gmail.com on 11 May 2010 at 11:00

GoogleCodeExporter commented 9 years ago 
Issue 209 has been merged into this issue.

Original comment by felix.bechstein on 11 May 2010 at 10:35

GoogleCodeExporter commented 9 years ago 
please test the rc3 from yesterday eve.
it should be fixed in there.

Original comment by felix.bechstein on 12 May 2010 at 6:40