search

iliyantn / websmsdroid

Automatically exported from code.google.com/p/websmsdroid
0 stars 0 forks source link

Easier provider-switching #214

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I just did some changes to the WebSMS.java in Method changeConnectorMenu().
The Behavior i liked to have was the following:

If i have only one Connector activated i wanted the program to just do
nothing, because the list would contain one entry only.
And then i wanted it to just switch to the othder connector if there were
just two activated connectors.

I did some c&p but i guess it would be prettier if you would place some
lines in a new function :)

Greetings,
nils

Original issue reported on code.google.com by clausthalerblubb on 17 May 2010 at 12:02

Attachments:

GoogleCodeExporter commented 9 years ago 
It was late yesterday...

Just did some refactoring.

Greetings,
nils

Original comment by clausthalerblubb on 17 May 2010 at 9:21

GoogleCodeExporter commented 9 years ago 
i'll review this as soon as possible.
thx!

Original comment by felix.bechstein on 20 May 2010 at 7:16

GoogleCodeExporter commented 9 years ago

Original comment by felix.bechstein on 22 May 2010 at 1:34

GoogleCodeExporter commented 9 years ago

Original comment by felix.bechstein on 23 May 2010 at 10:49

GoogleCodeExporter commented 9 years ago 
please test the attached apk.
i did minor changes to your commit.
you may want to review them on github.

yours: 
http://github.com/felixb/websms/commit/7d74316f45368042a1781696e16f79b7d6b6c8b0
cleanup: 
http://github.com/felixb/websms/commit/9b9d28bab0fcd1363c3d54686abbe6747c80b202

Original comment by felix.bechstein on 23 May 2010 at 11:14

Attachments:

GoogleCodeExporter commented 9 years ago 
Just tested and, it seems to be fine. Thank you very much :)

Original comment by clausthalerblubb on 24 May 2010 at 8:18

GoogleCodeExporter commented 9 years ago

Original comment by felix.bechstein on 25 May 2010 at 7:17