iljapostnovs / VSCodeUI5Plugin

Visual Studio Code Extension for UI5 Development
Apache License 2.0
61 stars 6 forks source link

Bug: Plugin 1.8.0 doesn't respect configured ui5version #344

Closed HymanZHAN closed 1 year ago

HymanZHAN commented 1 year ago

Describe the bug

In my package.json, I have:

    "ui5": {
        "dependencies": [
            "@dwc/ui5-middleware-dwc"
        ],
        "ui5parser": {
            "ui5version": "1.114.0",
            "excludeFolderPatterns": ["**/resources/**", "**/dist/**", "**/node_modules/**", "**/test/**"]
        }
    },

Document links are linked to v1.84.30 docs. It seems the ui5version option is not respected during parsing.

To Reproduce Steps to reproduce the behavior:

  1. Open a UI5 project
  2. Open an XML file.
  3. Hover on any tag
  4. Click the "UI5 API" link

Expected behavior

The link should lead me to v1.114.0 docs.

Screenshots

Desktop (please complete the following information):

Additional context

I believe this is a regression.

Project attachment N/A

iljapostnovs commented 1 year ago

Hi!

Thanks for the bug report and it's very interesting one for me, because it works for me if I run the extension locally, however, with bundled package it works differently. I will take a look.

iljapostnovs commented 1 year ago

Can you try to launch UI5 Linter for your project?

npm install ui5plugin-linter -g
ui5linter

It outputs the UI5 Version, will it be 1.114.0 or 1.84.30?

HymanZHAN commented 1 year ago

It shows 1.114.0

image

iljapostnovs commented 1 year ago

Thanks!

Apparently, package for fetching rc files does not work well with webpack, because it uses dynamic requires, as a result the bundle is damaged. I will think how it can be solved.

iljapostnovs commented 1 year ago

Please try now

HymanZHAN commented 1 year ago

Seems to be working now.

image