search

iljapostnovs / VSCodeUI5Plugin

Visual Studio Code Extension for UI5 Development
Apache License 2.0
61 stars 6 forks source link

Add xml formatter setting to append a space before the self-closed tag end #372

Closed netux closed 11 months ago

netux commented 11 months ago

Adds the ui5.plugin.xmlFormatterSpaceAfterSelfTagEnd extension setting, which controls whether to include the space in between the last attribute and the tag end or not.

Example

<Text text="hello world"/>
<Text
  text="hello world"
  other="ignore"
  this="okay"/>

becomes

<Text text="hello world" />
<Text
  text="hello world"
  other="ignore"
  this="okay" />

Normal closing tags, or tags on new lines, are ignored.

iljapostnovs commented 11 months ago

Hi,

Thank you for pull request and sorry for the late response, however, per request #130, XML formatter was moved to ui5plugin-linter. So, would you like to create pull request there or would you prefer me to add your changes by myself instead?

netux commented 11 months ago

Hi,

Thank you for pull request and sorry for the late response, however, per request #130, XML formatter was moved to ui5plugin-linter. So, would you like to create pull request there or would you prefer me to add your changes by myself instead?

Sure! I have gone ahead and made the PR there. See iljapostnovs/ui5plugin-linter#133.

It may be worth keeping this PR here so we can integrate the flag as a VSCode setting as well once the other PR is merged.

iljapostnovs commented 11 months ago

Changes added in PR #374