Bug: Reference counting does not recognize closure references in consuming modules.

[richardatsap]

Describe the bug

• I have a module in the project ("Util" module in the example project)
• A reference to an instance of the module is set in the closure of another module (only a singleton is needed and should be kept private), see line 15 in MainApplication.controller.js.
• References to class members (line 21 in MainApplication) are not recognized in the original module (Util still counts 0 references to the member method).
• As well, code completion does not show members for completion.
• If the references are in members of the module, everything works as expected (lines 22, 23 when commented in).

To Reproduce See example project: ui5-minimal.zip

Expected behavior Reference counting and code completion should work also for references in a modules closure.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Ubuntu 20.04

[iljapostnovs]

Hi,

The code outside of the class body is not parsed by the extension, so, if you want this example to work as expected, put Util into the class itself:

[richardatsap]

Hi,

I use that pattern at a couple of places, that would be a major rewrite. As well, your suggestion will expose the reference to outside the consuming module which I would want to avoid.

I have the habit to put a bunch of stuff into the closure (=outside the class body), to enforce it being private. Eslint parses it just fine.

If you don't mind and it's feasible, take this as a feature request then ;-).

Kind Regards Richard

[iljapostnovs]

I will leave it as enhancement, no promises regarding when and if it will be done :)

[iljapostnovs]

It was actually easy to implement ;) Please check latest version and let me know if it works for you

[richardatsap]

Hi,

works like a charm. Thanks for fixing this.

Kind Regards Richard