search

iljapostnovs / VSCodeUI5Plugin

Visual Studio Code Extension for UI5 Development
Apache License 2.0
61 stars 6 forks source link

Bug: xml linter exceptions narrowed to properties do not work as documented #396

Closed richardatsap closed 7 months ago

richardatsap commented 7 months ago

Describe the bug In https://github.com/iljapostnovs/ui5plugin-linter/tree/master#view-and-fragment-errors it is explained that one can define linting exception at property level. This does not work.

To Reproduce Steps to reproduce the behavior:

  1. Add a random property in an xml view
  2. Put a @ui5ignore comment before the enclosing tag
  3. The error displayed goes away
  4. Add the property after @ui5ignore
  5. The property is still marked as faulty

Expected behavior The linting exception should be honored as described in the ui5plugin-linter.

Screenshots XML Linter Exception

Desktop (please complete the following information):

iljapostnovs commented 7 months ago

Hi, thanks for the report! Please check if latest version (1.16.6) works for you.

richardatsap commented 7 months ago

Works like a charm. Thanks for fixing that quickly!