Bug: JS linter: Overriding deprecated methods does not emit a warning.

iljapostnovs / VSCodeUI5Plugin

Visual Studio Code Extension for UI5 Development

Apache License 2.0

61 stars 6 forks source link

Closed richardatsap closed 7 months ago

richardatsap commented 7 months ago

Describe the bug When overriding a deprecated method, no warning is emitted. However, calling deprecated overridden methods emits a warning.

To Reproduce Steps to reproduce the behavior:

Switch to UI5 version 1.120
In a class inheriting from sap.ui.core.UIComponent, override the deprecated method onWIndowBeforeUnload. The method name is not marked in any way.

Expected behavior There should be a warning similar to calling a deprecated method.

iljapostnovs commented 7 months ago

That never was part of the functionality, but I've added it to WrongOverrideLinter :) Please check v1.17.0

richardatsap commented 7 months ago

Works, thanks for the quick fix!