Add PlayersScreen - Githubissues

ilkeraslan commented 2 years ago

We should have a Players Screen which is capable of showing professional Dota2 players.

In this task:

[ ] This Screen should be integrated into Bottom Navigation like HeroesScreen and TeamsScreen.
[ ] The Screen should show the players by their rank in descending order.

The Screen should be built using Jetpack Compose.

This issue is blocked by #4, so you can mock a list of 20 players in a separate file and show that. When #4 is resolved, another issue will be created to integrate the real repository.

ahmetkca commented 1 year ago

I could take this issue as well.

erik1906 commented 1 year ago

Hey i was wonder if this issue still needs help

ilkeraslan commented 1 year ago

Hey i was wonder if this issue still needs help

Hey Erik, sure I am assigning this to you. Feel free to ask if you have any questions!

erik1906 commented 1 year ago

For the second task

The Screen should show the players by their rank in descending order.

i don't see a good way to do the order, the endpoint GET/proPlayers don't have any rank field and getting another request to see the rank could use a lot of bandwidth

ilkeraslan / dota2compose

Add PlayersScreen #3

This issue is blocked by #4, so you can mock a list of 20 players in a separate file and show that. When #4 is resolved, another issue will be created to integrate the real repository.