search

ilkerccom / bitcrackrandomiser

Solo pool for Bitcoin Puzzle Transaction 66, 67 and 68.
https://btcpuzzle.info/
MIT License
85 stars 41 forks source link

telegram_share_eachkey=false ignored #30

Closed krishnathon2006 closed 8 months ago

krishnathon2006 commented 8 months ago

Starting version 1.2.0.0, telegram_share_eachkey=false settings is ignored and my Telegram channel filled with "scanned by" messages from my worker.

krishnathon2006 commented 8 months ago

I've checked 1.0.8.0 and confirmed that telegram_share_eachkey=false setting is respected there. As expected, I receive "started job for" at the start of the app, but don't receive notifications for each key scan. Looks like there is some regression between these two versions

ilkerccom commented 8 months ago

I will fix the problem in the next version; If you want to solve it quickly, you can make the following change and get a new build;

https://github.com/ilkerccom/bitcrackrandomiser/blame/main/BitcrackRandomiser/Randomiser.cs#L227

It will be enough to put this code in the "if" block;

if (settings.TelegramShareEachKey)
{
    Helpers.ShareTelegram(string.Format("[{0}] scanned by [{1}].[{2}]", HEX, Helpers.StringParser(settings.ParsedWalletAddress), settings.ParsedWorkerName), settings);
}

Working example on v1.0.8.0; https://github.com/ilkerccom/bitcrackrandomiser/blame/v1.0.8.0/BitcrackRandomiser/Program.cs#L258-L261

ilkerccom commented 8 months ago

Fixed. ff97dcc