search

ilkerogutcu / keydrop-giveaway-bot

KeyDrop Giveaway Bot is an request-based automatic join bot for the KeyDrop website's giveaways.
Apache License 2.0
8 stars 5 forks source link

Add Dockerfile #6

Closed signed-log closed 1 year ago

signed-log commented 1 year ago

Untested attempt to do something for #5

Can't test it, and it requires rebuild for every appsettings.json change, but should work

jsardev commented 1 year ago

@signed-log Thanks for the PR! I wonder - why not use one of the official .NET docker images? Bitnami is a 3rd party AFAIK (and not sure if the image is any lightweight 🤔 ). Will try to test it out in the following week.

signed-log commented 1 year ago

I didn't know they actually existed

Bitnami is a VMWare program that produces many software images and has been really reliable for me

jsardev commented 1 year ago

The smallest official image (7.0-alpine-amd64) is 240 MB, and the bitnami/dotnet-sdk is 374.44 MB. Not a huge improvement, but I think worth trying.

I often worry about the weight as container registries are not free and you need to host it somewhere 😅

Anyways, I'll try to test it out in the next few days 😃

ilkerogutcu commented 1 year ago

I tried to run the project with my dockerfile, but I'm getting an error when trying to retrieve the vioshield value. I think the reason for the error is related to the chrome driver because I'm using Selenium in the project. Do you know anything about this?

signed-log commented 1 year ago

Oh, it uses chromedriver? I will not work in this state at all, will fix as soon as possible

ilkerogutcu commented 1 year ago

Yes, I had to use Selenium to bypass Cloudflare.

jsardev commented 1 year ago

I had some time to work on this and created a separate PR. It works, so I guess we can close this one 😄