search

illacloud / illacloud.com

ILLA official site project.
https://illacloud.com
44 stars 16 forks source link

Fix ILLA logo button on hacktoberfest page. #268

Open Priyansh121096 opened 1 year ago

Priyansh121096 commented 1 year ago

The button is clickable but the cursor does not turn into a pointer because it's a span, not an anchor. The same works fine in Nav of the homepage which uses an anchor tag (ref).

This is the button this PR fixes (unfortunately I'm not able to take a screenshot with a visible mouse pointer): image

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **illafamily-com** | ⬜️ Ignored ([Inspect](https://vercel.com/illacloud/illafamily-com/EqbjQv9bmHoZ8awc78zpZrckjqg7)) | [Visit Preview](https://illafamily-com-git-fork-priyansh121096-main-illacloud.vercel.app) | | Oct 14, 2023 6:51pm |
Priyansh121096 commented 1 year ago

Also, I was wondering whether, if this is approved, it'll be possible to label this with hacktoberfest-accepted so that it can count towards my hacktoberfest contributions. To be clear, I am aware that this will not count towards "Build with ILLA" contributions which are eligible for swag.

Priyansh121096 commented 1 year ago

Hello, just wanted to see if anyone got a chance to look at this. Thanks!