illandril / FoundryVTT-npc-quick-actions

MIT License
4 stars 2 forks source link

[Feature Request] Hide unleveled spells from list option #42

Closed SLinxTheFox closed 5 months ago

SLinxTheFox commented 5 months ago

Is your feature request related to a problem? Please describe

The list gets comically long with leveled spells. It'd be great if there was an option to hide unleveled spells from the list. I thought there was already an option for this, but I think I was thinking of the actions list module

Describe the solution you'd like

An option like the others that can be toggled on and off to show or hide all non cantrip spells

What system(s) do you want this feature to work with?

DnD5e - Fifth Edition System

illandril commented 5 months ago

Instead of hiding and showing arbitrary groups of actions, I think I am going to add an option to only actions associated with "Favorites" for PC actors.

This should work as a more flexible solution (with a little extra initial setup), as long as there isn't some reason why someone would want to limit their quick actions list in a different way to their favorites.

SLinxTheFox commented 5 months ago

That should work, I don't think most monsters should have too many spells listed. the worst would probably be something like the archmage.

It's mostly an issue for characters with character sheets

SLinxTheFox commented 5 months ago

I just updated and turned on the option, but stuff outside of the favorites menu on all characters I tried was still showing. I turned all modules off other than this one and the same result.

I'm on V11 315 dnd 5e 3.1.2 btw if that makes any difference

illandril commented 5 months ago

I'm on v12 327, and dnd5e 3.2.0, so I can't easily downgrade to your version to test in that version.

Are you using any other modules? If so, what modules (and what versions)?

Are you using the Default 5e Character Sheet? If not, try using the Default 5e Character Sheet to make sure you're using the same Favorites.

Did you have at least one thing in the favorites list for the characters you tried? If a character has nothing in their favorites list, it will act as if the setting was off for those characters.

If you see the issue with no other modules on, and have confirmed you have favorites set for the character... turn on Debug Mode, open up the browser Developer Tools, open the "Verbose" logging in the console, and then right-click on the character. In the Dev Tools, you should see a whole bunch of messages show up. Find one of the log messages that says getAction() with an Actor5e and Item5e listed under it...

Screenshot 2024-06-09 194011

Expand the Actor, then expand system under the actor, then favorites under system...

Screenshot 2024-06-09 194043

Copy the favorites (or take a screenshot of them).

Then, take a screenshot both the Favorites in the character's sheet and the Quick Actions menu open...

Screenshot 2024-06-09 194113 Screenshot 2024-06-09 194103

SLinxTheFox commented 5 months ago

I.. see. I had tested it without modules, but apparently tidysheet's favorites don't actually use the built in favorites system. Least far as i can tell since it started working once i added a favorite via the 3.x.x 5e system sheet.

Thanks for the help and the update and sorry for not noticing that when i tested it the first time