Actor gains 4th level slots a level too early

[leagueoffoundryvttdevs]

Submitted By: @JustinTheDM#5827 Feedback Type: Bug

Core: 0.8.9 System: dnd5e v1.4.3 Module Version: illandril-third-pact v1.2.3

Description: The actor I have configured with custom pact magic progression gained 4th level slots at 8th level; according to the config, slots should upgrade to 4th at CL8.

Module Settings

roundingMode: standard,
illandril_custompact_a: [{"slots":1,"spellLevel":1},{"slots":2,"spellLevel":1},{"slots":2,"spellLevel":1},{"slots":2,"spellLevel":2},{"slots":3,"spellLevel":2},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":4},{"slots":3,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":5},{"slots":4,"spellLevel":5},{"slots":4,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5}],
illandril_custompact_b: ,
illandril_custompact_c: ,
hitDice-d4: false,
hitDice-d20: false

Active Modules

ATL--v0.2.17; ActiveAuras--v0.3.08; CautiousGamemastersPack--v0.4.1; CommunityLighting--v0.4.7; Custom-Token-Animations--v0.2.51; Dynamic-Effects-SRD--v6.0.01; LockView--v1.4.14; My-Shared-Compendia--v1.0.0; TokensVisible--v2.7.0; WallCutter--v1.1.1; _mathjs--v7.5.1-fvtt2; about-time--v1.0.4; actor-attribute-lists--v0.0.5; advanced-macros--v1.11; autoanimations--v0.6.33; better-rolltables--v1.8.3; betterroofs--v0.9.9.3; bug-reporter--v1.3.2; colorsettings--v2.8.0; combat-utility-belt--v1.6.2; compendium-folders--v2.3.53; condition-automation--v3.0.2; custom-classes--v0.1.00; cycle-token-stack--v0.5.4; dae--v0.8.57; danger-zone--v0.0.9; ddb-importer--v2.5.18; df-settings-clarity--v3.2.1; dfreds-convenient-effects--v1.13.0; dice-calculator--v1.2.1; dnd5e-helpers--v3.0.2; enhancedcombathud--v0.9.3; fa-dm-screen--v0.4.1; fateroll--v0.4.5; find-the-culprit--v1.4.0; force-client-settings--v1.0.3; forien-copy-environment--v2.0.6; forien-quest-log--v0.7.7; forien-unidentified-items--v0.3.17; foundry_community_macros--v0.48.0; foundry_community_tables--v0.17.0; foundryvtt-simple-calendar--vv1.3.66; fxmaster--v1.2.1; gm-notes--v0.4.1; gm-screen--v2.8.1; illandril-third-pact--v1.2.3; inventory-plus--v0.3.5; itemacro--v1.5.5; jb2a_patreon--v0.2.8; koboldpressogl--v0.26; levels--v1.9.7; lib-changelogs--v0.4; lib-df-hotkeys--v2.3.5; lib-find-the-path--v1.5.0; lib-wrapper--v1.10.6.0; lmrtfy--v1.20; lootsheetnpc5e--v3.1.0; magicitems--v2.1.2; midi-qol--v0.8.67; midi-srd--v0.1.02; mob-attack-tool--v0.3.11; module-sets--v1.0.1; monks-active-tiles--v1.0.30; monks-little-details--v1.0.37; monks-scene-navigation--v1.0.17; monks-tokenbar--v1.0.52; mookAI--v0.2.0; moulinette-core--v3.8.0; moulinette-imagesearch--v2.3.0; moulinette-scenes--v2.10.0; moulinette-tiles--v3.5.1; multiface-tiles--v1.0.2; party-overview--v2.5.13; permission_viewer--v0.8.10; ping-logger--v1.2.10; plutonium--v1.39.2; resourcesplus--v1.6.11; roll-from-compendium--v1.1.2; rounded-distance-for-measured-templates--v0.5.1; searchanywhere--v2.2.0; select-tool-everywhere--v1.2.0; sequencer--v1.1.0; settings-extender--v1.1.6+0.8.6; siftoolkit--v0.1.29; smalltime--v1.13.3; smart-doors--v1.2.9; smarttarget--v0.6.6; socketlib--v1.0.9; t-is-for-target--v0.4; template-wall-collision--v1.0.3; tidy-ui_game-settings--v0.1.25; tidy5e-sheet--v0.5.16; times-up--v0.8.19; token-action-hud--v1.3.13; token-attacher--v4.2.0; token-variants--v1.12.2; tokenmagic--v0.5.2.1; turnAlert--v2.0.0; wall-height--v3.6.0.0; wild-magic-surge-5e--v1.3.0; wonderwalls--v0.1.01; zsync--v0.0.4; srd5e--v1.39.2;

Additional Details

undefined

[justinrpurdy]

Mistyped above - slots should upgrade to 4th level at CL9, not CL8.

[illandril]

I was unable to reproduce this - when I use your JSON, at level 8 the character has 3 level 3 slots, and at level 9 they have 3 level 4 slots. Is the character multi-classed? Can you double-check to make sure the class's "Spell Progression" is set to "Custom Pact Caster A"?

I did find a different issue that might be related - I fixed that issue and added some additional logging in 1.2.4. Can you update, and see if you still see the issue?

If you do, open up the browser dev tools, turn on debug logging, and filter the output to "Illandril's Third", and then refresh your browser.

You should see something like this in the console output (with "Custom A 1" replaced by the name of the character you're using with custom pact slots):

Illandril's Third Pact Slot | Refreshing Pact Slots for Custom A 1 module.js:6:9
Illandril's Third Pact Slot | Actor[Custom A 1] has at least one pact class module.js:6:9
Illandril's Third Pact Slot | Deriving pact slots for Custom A 1 module.js:6:9
Illandril's Third Pact Slot | Actor[Custom A 1] has a custom pact slot class module.js:6:9
Illandril's Third Pact Slot | Custom pact options for [illandril_custompact_a]: [{"slots":1,"spellLevel":1},{"slots":2,"spellLevel":1},{"slots":2,"spellLevel":1},{"slots":2,"spellLevel":2},{"slots":3,"spellLevel":2},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":4},{"slots":3,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":5},{"slots":4,"spellLevel":5},{"slots":4,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5}] module.js:6:9
Illandril's Third Pact Slot | Custom pact options for level 8: {"slots":3,"spellLevel":3} module.js:6:9
Illandril's Third Pact Slot | Calculated pact slots for customPactClass[illandril_custompact_a]: {"value":0,"override":null,"max":3,"level":3} module.js:6:9

[justinrpurdy]

That was it! Not sure how, but the actor had been set back to normal Pact Magic. Thanks!

On Sun, Oct 10, 2021, 10:17 AM Joe Spandrusyszyn @.***> wrote:

I was unable to reproduce this - when I use your JSON, at level 8 the character has 3 level 3 slots, and at level 9 they have 3 level 4 slots. Is the character multi-classed? Can you double-check to make sure the class's "Spell Progression" is set to "Custom Pact Caster A"?

I did find a different issue that might be related - I fixed that issue and added some additional logging in 1.2.4. Can you update, and see if you still see the issue?

If you do, open up the browser dev tools, turn on debug logging, and filter the output to "Illandril's Third", and then refresh your browser.

You should see something like this in the console output (with "Custom A 1" replaced by the name of the character you're using with custom pact slots):

Illandril's Third Pact Slot | Refreshing Pact Slots for Custom A 1 module.js:6:9 Illandril's Third Pact Slot | Actor[Custom A 1] has at least one pact class module.js:6:9 Illandril's Third Pact Slot | Deriving pact slots for Custom A 1 module.js:6:9 Illandril's Third Pact Slot | Actor[Custom A 1] has a custom pact slot class module.js:6:9 Illandril's Third Pact Slot | Custom pact options for [illandril_custompact_a]: [{"slots":1,"spellLevel":1},{"slots":2,"spellLevel":1},{"slots":2,"spellLevel":1},{"slots":2,"spellLevel":2},{"slots":3,"spellLevel":2},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":3},{"slots":3,"spellLevel":4},{"slots":3,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":4},{"slots":4,"spellLevel":5},{"slots":4,"spellLevel":5},{"slots":4,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5},{"slots":5,"spellLevel":5}] module.js:6:9 Illandril's Third Pact Slot | Custom pact options for level 8: {"slots":3,"spellLevel":3} module.js:6:9 Illandril's Third Pact Slot | Calculated pact slots for customPactClass[illandril_custompact_a]: {"value":0,"override":null,"max":3,"level":3} module.js:6:9

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/illandril/FoundryVTT-third-pact/issues/8#issuecomment-939500432, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP5RVEDW4K6KVYXYAU2BWMLUGGVCNANCNFSM5FVWGGCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.