illiath / EnhancedFlightMap

Flight addon for WoW
Apache License 2.0
3 stars 7 forks source link

Feature request: Use reverse flight times to calculate unknown timers #2

Closed beren12 closed 4 years ago

beren12 commented 5 years ago

Is it possible to use the opposing flight time as a guesstimate for the current flight? This way there could be at least approximate timers for flights until they are recorded, as long as the other direction is recorded.

illiath commented 5 years ago

I was noticing this was not included in the current code base, but at one time I did do this. I think the reason I pulled it from the addon after the last time it was there was the huge discrepancies seen between the two different directions for some flight paths.

Given that I don't know why it was removed last time

WildCard-25 commented 5 years ago

Someone asked me the same question not so long ago. My reply was

A->B and B->A are almost never the same. Sometimes they can be close, other times there can be over 30 seconds difference. eg. Stormwind->Ironforge=4:19, Ironforge->Stormwind=3:30, that's a difference of nearly 50 seconds. Orgrimmar->Ratchet=2:42, Ratchet->Orgrimmar=3:30, again nearly 50 seconds difference.

Since then I have found many, many more. All just one-hop flights, so longer flights would be exponentially worse. Of course, this is just my own opinion. :-)

illiath commented 5 years ago

Thanks! I knew there was a reason, but I wasn't sure what the reason was. I think I'll add this as a "you have to turn this feature on if you want it because it WILL get things wrong" type option in the config. I've also flagged this as low priority given the time discrepencies that are known, so actual bugs and enhancements with no obvious problems will be addressed first.

beren12 commented 5 years ago

Well, maybe put it in red instead of "Calculated" use "Estimated". Calculated is if you know all the times in between.

illiath commented 5 years ago

I think I'd be okay with it displaying that way. I will have to go look at the timer display code to make sure it's not entirely horrible to arrange. If it will only take a few minutes (hahahaha), then I'll likely do it that way. Basically... the "Here be Dwagons" display would likely resolve the concerns regarding getting bug reports because "the flight times are wrong here"...

beren12 commented 4 years ago

Not really needed now, no worries!