search

illiliti / libudev-zero

Daemonless replacement for libudev
ISC License
202 stars 22 forks source link

Adding version symbol to Makefile #38

Closed Rio6 closed 3 years ago

Rio6 commented 3 years ago

Right now when using some libraries like libusb, the dynamic linker would complain about missing version symbols (but the program still works fine). For example when using adb:

$ adb
adb: /usr/lib/libudev.so.1: no version information available (required by /usr/lib/libusb-1.0.so.0)
Android Debug Bridge version 1.0.41
Version 31.0.2-android-tools
Installed as /usr/bin/adb

I'm not sure how libudev-zero map to systemd versions, but if we can add a file like this https://github.com/systemd/systemd/blob/main/src/libudev/libudev.sym and using it when linking we can get rid of the warning.

Rio6 commented 3 years ago

An empty LIBUDEV_183 {}; seems to work too for my case with adb.

TAAPArthur commented 3 years ago

@illiliti Just a heads up that 000ff7b broke complication with tcc tcc: error: unsupported linker option '-version-script,libudev.sym' Which is simply enough for the user to resolve. But think breaking complication outweighs the benefits of silencing a warning.

Rio6 commented 3 years ago

as mentioned in https://github.com/illiliti/libudev-zero/pull/40#issuecomment-939492896, arcan requires symbol versioning to be there, so it's not just a warning in some cases.

illiliti commented 3 years ago

Reverted. Trying to catch up with upstream is not good idea here