Allow limiter to optionally pass back p, T. This can break things if the limiter passes back invalid p, T , but it is a performance bottleneck to disallow it when we trust that the driver-implemented limiter is returning the correct p, T.
(This is not adding a new behavior, it is optionally allowing the old behavior)
Questions for the review:
[ ] Is the scope and purpose of the PR clear?
[ ] The PR should have a description.
[ ] The PR should have a guide if needed (e.g., an ordering).
[ ] Is every top-level method and class documented? Are things that should be documented actually so?
[ ] Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
[ ] Does the implementation do what the docstring claims?
[ ] Is everything that is implemented covered by tests?
[ ] Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?
anderson2981
commented
3 months ago
Allow limiter to optionally pass back p, T. This can break things if the limiter passes back invalid p, T , but it is a performance bottleneck to disallow it when we trust that the driver-implemented limiter is returning the correct p, T.
(This is not adding a new behavior, it is optionally allowing the old behavior)
Questions for the review: