illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.
Other
12 stars 19 forks source link

add functionality to get temperature from enthalpy #1036

Closed anderson2981 closed 4 months ago

anderson2981 commented 4 months ago

Questions for the review:

anderson2981 commented 4 months ago

probably could add some tests to check that enthalpy matches with temperature and energy.

Should also be able to refactor into 1 function that does both, like in pyrometheus.

MTCam commented 4 months ago

probably could add some tests to check that enthalpy matches with temperature and energy.

Should also be able to refactor into 1 function that does both, like in pyrometheus.

Cool, just added #1037 to align this with mixture fraction eos changes. Unified energy/enthalpy interface and update func.