illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.
Other
12 stars 19 forks source link

Look for missing harmonic means in fluxes #611

Open inducer opened 2 years ago

inducer commented 2 years ago

When considering diffusive fluxes with coefficients "on the time derivative side" that can be discontinous, we should be using harmonic means. (As @majosm is heading towards with fluid/solid heat conduction). Look through our interior and boundary numerical fluxes where that's missing.

cc @MTCam @anderson2981 @lukeolson

majosm commented 2 years ago

A derivation of the harmonic mean for FV is here (search for "harmonic"): https://www.cae.tntech.edu/~shan/numerical%20heat%20transfer%20note(ME4730_5730)/1d-condution(2013).pdf

A quick attempt at justifying it for DG is here: https://notes.tiker.net/_jxEbQ5SSHSy24IKyQXjkQ