Preparing to add ESDG as a prediction option. This change set adds a fluid_operator argument to the multiphysics interface. The idea is that setting the fluid_operator is in the hands of the driver. The driver will set it to:
ns_operator
-or-
entropy_stable_ns_operator (once its moved down out of #877 )
The multiphysics example is modified to illustrate the planned usage pattern.
Questions for the review:
[ ] Is the scope and purpose of the PR clear?
[ ] The PR should have a description.
[ ] The PR should have a guide if needed (e.g., an ordering).
[ ] Is every top-level method and class documented? Are things that should be documented actually so?
[ ] Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
[ ] Does the implementation do what the docstring claims?
[ ] Is everything that is implemented covered by tests?
[ ] Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?
Preparing to add ESDG as a prediction option. This change set adds a
fluid_operator
argument to the multiphysics interface. The idea is that setting thefluid_operator
is in the hands of the driver. The driver will set it to:ns_operator
-or-entropy_stable_ns_operator
(once its moved down out of #877 )The multiphysics example is modified to illustrate the planned usage pattern.
Questions for the review: