illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.
Other
11 stars 19 forks source link

expose coupled gradient computation #914

Closed anderson2981 closed 1 year ago

anderson2981 commented 1 year ago

This encapsulates the part that updates the boundaries and computes the gradients for the coupled system. Basically everything that gets done before calling ns_operator and diffusion_operator. This is required when the driver needs the gradients to compute some other mesh properties, e.g. artificial viscosity.

Updates coupled_ns_heat_operator to use the new implementation.

Questions for the review:

anderson2981 commented 1 year ago

I wonder if we'd be better off just switching over to the driver-defined coupling as implemented in #902? I think @tulioricci is already using it.

It's certainly possible. I wasn't aware of the other development, so I just tried to rework what was here to support what I wanted to do. At the end of what I did, I don't actually need coupled_ns_operator anymore, I can just directly call the ns_operator and diffusion_operator directly from the driver, but I wanted to preserve other drivers that were using it and have them use the new api.

majosm commented 1 year ago

Is there anything in this PR that we still want to add? Or did #902 mostly cover it?

anderson2981 commented 1 year ago

no longer needed.