Closed aakankshbhat closed 1 year ago
Hi @aakankshbhat , before you commit any changes, load the mirgecom environment and run "flake8 .py" and "pydocstyle .py" so you can catch any errors with flake8 or docs without having to go through CI. That will make your life easier. You can also run the examples to make sure there are no issues before committing and pushing.
Hi @aakankshbhat , before you commit any changes, load the mirgecom environment and run "flake8 .py" and "pydocstyle .py" so you can catch any errors with flake8 or docs without having to go through CI. That will make your life easier. You can also run the examples to make sure there are no issues before committing and pushing.
Actually, if you save this bit of code as pre-commit
in mirgecom/.git/hooks, then it will basically do what Tulio suggests above, and make sure everything is up-to-snuff at commit time automatically. It can get annoying every time, but can disable it on a case-by-case basis by specifying the -n
option when committing if you don't want to run the hooks.
https://gist.github.com/MTCam/c9b7b58bdcd0cc72c1501b537cf3bb66
Updated get_box_mesh function
Questions for the review: