Closed tulioricci closed 1 year ago
I forgot to mention: I have an idea to simplify make_fluid_state
a little. I'll give it a shot, and if it pans out I'll make a PR (I won't let that hold up this PR though).
Hi @majosm, I think I covered all the points you raised. I couldn't reply directly wrt the eos
and wall_eos
in the transport variables, but with the latest changes, now it has the same structure of pure gas. I don't know if it is worth to remove one argument but add the classes in the init, as you suggested. It doesn't look like a significant improvement.
Also, note that I renamed wall_model
in PorousFlowModel
to wall_eos
to keep consistency with the gas nomenclature. Hopefully this also helps makes things more clear.
Some cosmetic changes and initial steps towards a more thorough refactor of the gas-wall structure (#930)
wall_model
mask_from_elements
toutils
PorousFlowFluidState
to uncouple the wall density fromdv
to the newwv
, as well as existing wall dependent varswdv
towv
PorousFlowModel
that considers the wall thermophysical properties.PorousWallTransport
coupling gas and wall propertiesablation_workshop
example is inside that driver. Now the material files are cleaner and more "prediction targeted"Questions for the review @MTCam:
After quick first pass, looks good to me, just need to have a more detailed look to check the rest of the boxes.