illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.
Other
11 stars 19 forks source link

Reorganize a bit the structure of the wall files #935

Closed tulioricci closed 1 year ago

tulioricci commented 1 year ago

Some cosmetic changes and initial steps towards a more thorough refactor of the gas-wall structure (#930)

Questions for the review @MTCam:

After quick first pass, looks good to me, just need to have a more detailed look to check the rest of the boxes.

majosm commented 1 year ago

I forgot to mention: I have an idea to simplify make_fluid_state a little. I'll give it a shot, and if it pans out I'll make a PR (I won't let that hold up this PR though).

tulioricci commented 1 year ago

Hi @majosm, I think I covered all the points you raised. I couldn't reply directly wrt the eos and wall_eos in the transport variables, but with the latest changes, now it has the same structure of pure gas. I don't know if it is worth to remove one argument but add the classes in the init, as you suggested. It doesn't look like a significant improvement.

Also, note that I renamed wall_model in PorousFlowModel to wall_eos to keep consistency with the gas nomenclature. Hopefully this also helps makes things more clear.