illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.
Other
11 stars 19 forks source link

restructure examples v2 #954

Closed matthiasdiener closed 1 year ago

matthiasdiener commented 1 year ago

Continuation of #950, without the more contentious dependency on #948.

Questions for the review:

tulioricci commented 1 year ago

All examples will be running with lazy? I am afraid that the compilation time with ESDG and NS coupling will make CI take a few extra hours.

matthiasdiener commented 1 year ago

All examples will be running with lazy? I am afraid that the compilation time with ESDG and NS coupling will make CI take a few extra hours.

If it turns out to be an issue, we could manually blacklist those long-running examples inside (e.g.) run_examples.sh.

MTCam commented 1 year ago

All examples will be running with lazy? I am afraid that the compilation time with ESDG and NS coupling will make CI take a few extra hours.

We might need a mechanism to allow black-listing of certain examples from being run in certain ways. Not sure. Currently, the CI time isn't terrible. pytest still takes longer than the examples. Running all the examples in lazy isn't really new, but having no way to control which ones are run in lazy is new.