add force_compile function

illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.

Other

11 stars 19 forks source link

add force_compile function #974

Closed matthiasdiener closed 10 months ago

matthiasdiener commented 10 months ago

Questions for the review:

[ ] Is the scope and purpose of the PR clear?
- [ ] The PR should have a description.
- [ ] The PR should have a guide if needed (e.g., an ordering).
[ ] Is every top-level method and class documented? Are things that should be documented actually so?
[ ] Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
[ ] Does the implementation do what the docstring claims?
[ ] Is everything that is implemented covered by tests?
[ ] Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

majosm commented 10 months ago

Is this mainly for measuring the compile time? If so, I wonder if we shouldn't force_evaluate the arguments on the inside, since that could throw off the times. Maybe it should forbid passing unevaluated inputs?

matthiasdiener commented 10 months ago

Is this mainly for measuring the compile time?

Yes, another use case is debugging determinism/caching issues.

If so, I wonder if we shouldn't force_evaluate the arguments on the inside, since that could throw off the times. Maybe it should forbid passing unevaluated inputs?

Hmm, not sure. For profiling compile time, I think the measurement should be done inside the function anyways (so you can choose whether to profile .compile(), or the function call, or both). I think moving the force_evaluation outside wouldn't really help much.