illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.
Other
11 stars 19 forks source link

Update cantera to version 3.0.0 #989

Closed tulioricci closed 6 months ago

tulioricci commented 8 months ago

Questions for the review:

tulioricci commented 7 months ago

I am not sure I am comfortable removing the fluid stuff for this example. It is not wasted on me that it is largely non-participant in this example, but part of the example was showing how to have chem+fluid in the simulation.

My plan is to make autoignition for chemistry only (faster execution) and to add a 1D flame driver to verify spatial dependence + mixture transport models. I've been using both these cases for verification/debugging of chemistry in mirge-com. To avoid excess/superfluous examples, I want to remove mixture.py. See https://github.com/illinois-ceesd/mirgecom/pull/995

However, I can keep the spatial terms in autoignition. No big deal.

MTCam commented 7 months ago

My plan is to make autoignition for chemistry only (faster execution) and to add a 1D flame driver to verify spatial dependence + mixture transport models. I've been using both these cases for verification/debugging of chemistry in mirge-com. To avoid excess/superfluous examples, I want to remove mixture.py. See #995

However, I can keep the spatial terms in autoignition. No big deal.

I'm not opposed. Hearing your plan makes it seem like a good idea.